From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD4D1C433E0 for ; Mon, 22 Feb 2021 16:28:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C1CC64E29 for ; Mon, 22 Feb 2021 16:28:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231739AbhBVQ1m (ORCPT ); Mon, 22 Feb 2021 11:27:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231542AbhBVQ0A (ORCPT ); Mon, 22 Feb 2021 11:26:00 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D2DEC06178B for ; Mon, 22 Feb 2021 08:25:20 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id x16so14064578wmk.3 for ; Mon, 22 Feb 2021 08:25:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=VfspxvK2qmutul/HQI6CP6zvXTYbfiqNuFTl1ngzl9A=; b=Sa8IDK+hjxW/KTwxOZ5cq7ouchiX/NM/KOQCL18K15EPiODDMsHZ5XqNTpLH/qkUUW KsBasPKkGtF0X/YrvGKLM5qVd4Vaz1rXyh/DiLg9X1/ThY4/yoombEH4PrR4ER87vNGv aZ2YA+LXeyVFw8c4Vb+mdPGr0wpAL3bZhh+JE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=VfspxvK2qmutul/HQI6CP6zvXTYbfiqNuFTl1ngzl9A=; b=OttiMXQtEdKFoanCWFmwRYu61loCReohPJ+upQTkfW9ADcvRJW2JO7MZ0bRYxJ3wwr alrrKNrmTWN47iw4jBiERdst+iWWkB+tfr3IVG+6v91vmwJzH77YRpfQFqOYaEeBid7r 6gybCyOKNJ2L2ZJ4fwfuEyNdlVV4C+3ibcfXLtZpNtr+Y11/2CrXZmfQOQpcgInnDTFK 1vpCvwRSj45coBiLGB0sXtoV1X57oD1RFP1EmBpzw+Nft3uyMS6PXWqNYJtFGg51ttmF na2on8wNEElLvfn3X3TDKmv4om/iSTmMm1Td4Ol/7HMY1MA2MJFx35mvAUkutIf8CaHU Rzvw== X-Gm-Message-State: AOAM530HXGwKFU1ER/d24zOCG6yEiMbEiRBE5aK0mzflkq9mgaEPFE5d ffcRs1lFqZVr3GLv8X3meU8DGA== X-Google-Smtp-Source: ABdhPJyuox2nDrjMuRIMD73wg/ViwXcOZnkt/HhU49o9yGozLgztr5S8eyNLgIrHTwiFvZpcE+bwNQ== X-Received: by 2002:a1c:41d6:: with SMTP id o205mr20217128wma.80.1614011119077; Mon, 22 Feb 2021 08:25:19 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id u6sm31326161wmg.41.2021.02.22.08.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Feb 2021 08:25:17 -0800 (PST) Date: Mon, 22 Feb 2021 17:25:15 +0100 From: Daniel Vetter To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Sam Ravnborg , Daniel Vetter , David Airlie , Jani Nikula Subject: Re: [PATCH] fbdev: atyfb: add stubs for aty_{ld,st}_lcd() Message-ID: Mail-Followup-To: Randy Dunlap , linux-kernel@vger.kernel.org, kernel test robot , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Sam Ravnborg , David Airlie , Jani Nikula References: <20210222032853.21483-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210222032853.21483-1-rdunlap@infradead.org> X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 21, 2021 at 07:28:53PM -0800, Randy Dunlap wrote: > Fix build errors when these functions are not defined. > > ../drivers/video/fbdev/aty/atyfb_base.c: In function 'aty_power_mgmt': > ../drivers/video/fbdev/aty/atyfb_base.c:2002:7: error: implicit declaration of function 'aty_ld_lcd'; did you mean 'aty_ld_8'? [-Werror=implicit-function-declaration] > 2002 | pm = aty_ld_lcd(POWER_MANAGEMENT, par); > ../drivers/video/fbdev/aty/atyfb_base.c:2004:2: error: implicit declaration of function 'aty_st_lcd'; did you mean 'aty_st_8'? [-Werror=implicit-function-declaration] > 2004 | aty_st_lcd(POWER_MANAGEMENT, pm, par); > > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: Bartlomiej Zolnierkiewicz > Cc: Sam Ravnborg > Cc: Daniel Vetter > Cc: David Airlie > Cc: Jani Nikula stuffed into drm-misc-next-fixes for 5.12, thanks for your patch. -Daniel > --- > drivers/video/fbdev/aty/atyfb_base.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > --- linux-next-20210219.orig/drivers/video/fbdev/aty/atyfb_base.c > +++ linux-next-20210219/drivers/video/fbdev/aty/atyfb_base.c > @@ -175,6 +175,15 @@ u32 aty_ld_lcd(int index, const struct a > return aty_ld_le32(LCD_DATA, par); > } > } > +#else /* defined(CONFIG_PMAC_BACKLIGHT) || defined(CONFIG_FB_ATY_BACKLIGHT) \ > + defined(CONFIG_FB_ATY_GENERIC_LCD) */ > +void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) > +{ } > + > +u32 aty_ld_lcd(int index, const struct atyfb_par *par) > +{ > + return 0; > +} > #endif /* defined(CONFIG_PMAC_BACKLIGHT) || defined (CONFIG_FB_ATY_GENERIC_LCD) */ > > #ifdef CONFIG_FB_ATY_GENERIC_LCD -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch