From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06809C433DB for ; Fri, 26 Feb 2021 13:05:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACBB064D9F for ; Fri, 26 Feb 2021 13:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230175AbhBZNEy (ORCPT ); Fri, 26 Feb 2021 08:04:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:45704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230079AbhBZNEj (ORCPT ); Fri, 26 Feb 2021 08:04:39 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 32C5F64EE2; Fri, 26 Feb 2021 13:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614344639; bh=ZiJl8DpWEVCvIAtlfcxEMZ4oXLoAHaJv04eh0CYE7d0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0ml3fDh2uFY/AjFC4lthT/HDZ5Erk4mxqDdTIeSgPurDjrs59TOBDrcccL2Jm6kpG L45u7ZKpIcpRsrKRLwvbznTMT3RGKEGZ61K83V+IXy5uCszoRL96WhwekWnqt5iZxs iEMtOPFVEno5yP8A6ssdBpAGY2IeiPl2YoiY6H3Q= Date: Fri, 26 Feb 2021 14:03:55 +0100 From: Greg Kroah-Hartman To: Maciej Kwapulinski Cc: Arnd Bergmann , Jonathan Corbet , Derek Kiernan , Dragan Cvetic , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Tomasz Jankowski , Savo Novakovic , Jianxun Zhang Subject: Re: [PATCH v1 01/12] gna: add driver module Message-ID: References: <20210216160525.5028-1-maciej.kwapulinski@linux.intel.com> <20210216160525.5028-2-maciej.kwapulinski@linux.intel.com> <85wnuvrnml.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85wnuvrnml.fsf@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2021 at 01:59:14PM +0100, Maciej Kwapulinski wrote: > > Greg Kroah-Hartman writes: > > > On Tue, Feb 16, 2021 at 05:05:14PM +0100, Maciej Kwapulinski wrote: > .... > >> --- /dev/null > >> +++ b/drivers/misc/gna/gna_driver.h > >> @@ -0,0 +1,41 @@ > >> +/* SPDX-License-Identifier: GPL-2.0-only */ > >> +/* Copyright(c) 2017-2021 Intel Corporation */ > >> + > >> +#ifndef __GNA_DRIVER_H__ > >> +#define __GNA_DRIVER_H__ > >> + > >> +#include > >> +#include > >> +#include > >> + > >> +#define GNA_DRV_NAME "gna" > > > > Way too generic, no one knows what "gna" is. > > > > "intel gna" is much more verbose in search engines. > As we do not (plan to) have more "gna" drivers, is the following ok?: > > intel-gna > > the change would imply the following: > > prompt$ lspci -s 00:00.3 -vvvv > 00:00.3 System peripheral: Intel Corporation Device 3190 (rev 03) > Subsystem: Intel Corporation Device 2072 > .... > Kernel driver in use: intel-gna > Kernel modules: gna > > is it ok? Why not intel-gna as the kernel module as well? > also, how about the interface to library (it's part of one of next patches)?: > prompt$ file /dev/gna0 > /dev/gna0: character special (235/0) > > can "gna" stay intact here? Again, I have no idea what "gna" is, so you might want to pick something more descriptive? > I'm pointing this out, because gna exists on the market for a while and > changing the above may have some impact we'd like to avoid. If it exists but Linux does not support it, how would anyone know about it? :) Please use real terms where possible. thanks, greg k-h