From: Greg KH <gregkh@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Saravana Kannan <saravanak@google.com>
Subject: Re: [GIT PULL] Driver core / debugfs changes for 5.12-rc1
Date: Sat, 27 Feb 2021 15:26:57 +0100 [thread overview]
Message-ID: <YDpWsXwB6MJPjS7J@kroah.com> (raw)
In-Reply-To: <CAHk-=wj2kJRPWx8B09AAtzj+_g+T6UBX11TP0ebs1WJdTtv=WQ@mail.gmail.com>
On Wed, Feb 24, 2021 at 10:20:44AM -0800, Linus Torvalds wrote:
> On Wed, Feb 24, 2021 at 6:27 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > [..] I've reverted that change at
> > the very end so we don't have to worry about regressions in 5.12.
>
> Side note: it would have been really nice to see links to the actual
> problem reports in the revert commit.
Odd, this showed up in my gmail spam folder, just saw this now :(
> Yes, there's a "Link:" line there, but that points to the
> less-than-useful patch submission for the revert, not to the actual
> _reasons_ for the revert.
>
> Now I'm looking at that revert, and I have absolutely no idea why it
> happened. Only a very vague "there are still reported regressions
> happening".
>
> I've pulled it, but wanted to just point out that when there's some
> fairly fundamental revert like this, it really would be good to link
> to the problems, so that when people try to re-enable it, they have
> the history for why it didn't work the first time.
>
> Now all that history is basically lost (well, hopefully Saravana and
> you actually remember, but you get my point).
Sorry, the history is on the original commit Link that was reverted, and
in lots of other emails on lkml over the past few weeks. Next time I'll
include links to those threads as well.
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-27 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 14:27 Greg KH
2021-02-24 18:20 ` Linus Torvalds
2021-02-27 14:26 ` Greg KH [this message]
2021-03-01 7:41 ` Saravana Kannan
2021-02-24 18:46 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDpWsXwB6MJPjS7J@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@google.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome