From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA241C43381 for ; Mon, 1 Mar 2021 09:27:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE6C364E07 for ; Mon, 1 Mar 2021 09:27:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233912AbhCAJ1h (ORCPT ); Mon, 1 Mar 2021 04:27:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:44222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233896AbhCAJ1e (ORCPT ); Mon, 1 Mar 2021 04:27:34 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1F39164E45; Mon, 1 Mar 2021 09:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614590813; bh=VHgTRak+sl2GIrklguql/soqsfocI2iCaJWV3c8IHHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rGWMCEHvjKg+rR1m2mrP0pGyK+uM8DfH1ppCkDe+10csVsmBcl7bTgq8USCqzE3JJ n/OUqPeNZS3ZPs4O3urTjunt9CXRgwZMZxPDIKhjDrv8OA5UrYY5slDEyT4p5o9/J6 547SMOJkYMjI4x+w4ZS3ulgWOmZID0JQvMrTD74o= Date: Mon, 1 Mar 2021 10:26:51 +0100 From: Greg KH To: Yang Li Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] driver core: Switch to using the new API kobj_to_dev() Message-ID: References: <1614590004-69592-1-git-send-email-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1614590004-69592-1-git-send-email-yang.lee@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 01, 2021 at 05:13:24PM +0800, Yang Li wrote: > fixed the following coccicheck: > ./include/linux/device.h:590:46-47: WARNING opportunity for > kobj_to_dev() > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > include/linux/device.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/device.h b/include/linux/device.h > index ba66073..31d7137 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -587,7 +587,7 @@ struct device_link { > > static inline struct device *kobj_to_dev(struct kobject *kobj) > { > - return container_of(kobj, struct device, kobj); > + return kobj_to_dev(kobj); > } Did you test this change? Please do so... {sigh} greg k-h