From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Rob Herring <robh+dt@kernel.org>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: media: max9286: Describe gpio-hog
Date: Tue, 16 Mar 2021 00:15:16 +0200 [thread overview]
Message-ID: <YE/cdBtSx3cDIqCY@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210315163028.173148-2-jacopo+renesas@jmondi.org>
Hi Jacopo,
Thank you for the patch.
On Mon, Mar 15, 2021 at 05:30:25PM +0100, Jacopo Mondi wrote:
> The MAX9286 GMSL deserializer features gpio controller capabilities,
> as it provides 2 GPIO lines.
>
> As establishing a regulator that uses one of the GPIO lines and
> enabling/disabling it at run-time in the max9286 won't work due to
> a circular dependency on the gpio-controller/regulator creation, allow
> the usage of a gpio-hog for that purpose.
>
> The usage of the gpio-hog is required in designs where the MAX9286
> GPIO lines control the remote cameras power.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
That's really a workaround until we can find a good solution, do we have
to officially support it in the DT bindings ?
> ---
> .../bindings/media/i2c/maxim,max9286.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> index ee16102fdfe7..9038300e373c 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> @@ -177,6 +177,22 @@ properties:
>
> additionalProperties: false
>
> +patternProperties:
> + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
> + type: object
> + properties:
> + gpio-hog: true
> + gpios: true
> + output-low: true
> + line-name: true
> +
> + required:
> + - gpio-hog
> + - gpios
> + - output-low
> +
> + additionalProperties: false
> +
> required:
> - compatible
> - reg
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-03-15 22:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 16:30 [PATCH v2 0/4] arm64: dts: renesas: Enable GMSL on R8A77970 V3M Eagle Jacopo Mondi
2021-03-15 16:30 ` [PATCH v2 1/4] dt-bindings: media: max9286: Describe gpio-hog Jacopo Mondi
2021-03-15 22:15 ` Laurent Pinchart [this message]
2021-03-17 10:14 ` Jacopo Mondi
2021-03-17 11:06 ` Laurent Pinchart
2021-03-15 16:30 ` [PATCH v2 2/4] arm64: dts: renesas: eagle: Enable MAX9286 Jacopo Mondi
2021-03-15 22:22 ` Laurent Pinchart
2021-03-15 16:30 ` [PATCH v2 3/4] arm64: dts: renesas: eagle: Add GMSL .dtsi Jacopo Mondi
2021-03-15 22:29 ` Laurent Pinchart
2021-03-15 16:30 ` [PATCH v2 4/4] arm64: dts: renesas: eagle: Include eagle-gmsl Jacopo Mondi
2021-03-15 22:30 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YE/cdBtSx3cDIqCY@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®