From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C2BCC433E6 for ; Thu, 4 Mar 2021 08:14:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C16F064F11 for ; Thu, 4 Mar 2021 08:14:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236348AbhCDINt (ORCPT ); Thu, 4 Mar 2021 03:13:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:43974 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236327AbhCDINd (ORCPT ); Thu, 4 Mar 2021 03:13:33 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 35F8E64EA4; Thu, 4 Mar 2021 08:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614845572; bh=Dh3Ev/dCrImACq8JWfEYsh8ZVySaYfX1dN8xgdk2QZA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PzL/jrBFNamXglkuTttehjc037jgOVP78DjEl4JCAMSuM9evF4NuYe6gpNi3zQwgC S3XjEOft2/H6asBQ90PjwSc0jn+ad5gfHzi8k9PAcMNTHELD0YqASMox8Cts467AWM 0V9mcIf7Kj35A+xu31euLYR0L64XA+fbAenzdTMw= Date: Thu, 4 Mar 2021 09:12:50 +0100 From: Greg Kroah-Hartman To: "Yoo, Jae Hyun" Cc: Joel Stanley , John Wang , Linux Kernel Mailing List , "stable@vger.kernel.org" , Vernon Mauery , Sasha Levin Subject: Re: [PATCH 4.19 055/247] soc: aspeed: snoop: Add clock control logic Message-ID: References: <20210301161031.684018251@linuxfoundation.org> <20210301161034.369309830@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 02, 2021 at 12:09:21AM +0000, Yoo, Jae Hyun wrote: > > -----Original Message----- > > From: Joel Stanley > > Sent: Monday, March 1, 2021 2:44 PM > > To: Greg Kroah-Hartman ; John Wang > > ; Yoo, Jae Hyun > > > > Cc: Linux Kernel Mailing List ; > > stable@vger.kernel.org; Vernon Mauery ; > > Sasha Levin > > Subject: Re: [PATCH 4.19 055/247] soc: aspeed: snoop: Add clock control logic > > > > On Mon, 1 Mar 2021 at 16:37, Greg Kroah-Hartman > > wrote: > > > > > > From: Jae Hyun Yoo > > > > > > [ Upstream commit 3f94cf15583be554df7aaa651b8ff8e1b68fbe51 ] > > > > > > If LPC SNOOP driver is registered ahead of lpc-ctrl module, LPC SNOOP > > > block will be enabled without heart beating of LCLK until lpc-ctrl > > > enables the LCLK. This issue causes improper handling on host > > > interrupts when the host sends interrupt in that time frame. > > > Then kernel eventually forcibly disables the interrupt with dumping > > > stack and printing a 'nobody cared this irq' message out. > > > > > > To prevent this issue, all LPC sub-nodes should enable LCLK > > > individually so this patch adds clock control logic into the LPC SNOOP > > > driver. > > > > Jae, John; with this backported do we need to also provide a corresponding > > device tree change for the stable tree, otherwise this driver will no longer > > probe? > > Right. The second patch > https://lore.kernel.org/linux-arm-kernel/20201208091748.1920-2-wangzhiqiang.bj@bytedance.com/ > John submitted should be applied to stable tree too to make this module be probed > correctly. Now queued up, thanks. greg k-h