From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D21D5C43381 for ; Thu, 4 Mar 2021 13:02:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A8E164F3D for ; Thu, 4 Mar 2021 13:02:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241049AbhCDNBk (ORCPT ); Thu, 4 Mar 2021 08:01:40 -0500 Received: from mga02.intel.com ([134.134.136.20]:44828 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241029AbhCDNB0 (ORCPT ); Thu, 4 Mar 2021 08:01:26 -0500 IronPort-SDR: IoYt8sxBHQWAP7/05DA5PM8S3MzfT1GHJ2aykOo0yAvV5s/88AEggymMZMmhQR2U/J9KEgRyb1 0yFcQOYKRlHw== X-IronPort-AV: E=McAfee;i="6000,8403,9912"; a="174522763" X-IronPort-AV: E=Sophos;i="5.81,222,1610438400"; d="scan'208";a="174522763" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2021 04:59:34 -0800 IronPort-SDR: k2j+hBVdNsYKiTq+pJGL+2IceTMyHuIjVTCHuM2/U6sNs3dpQ6VoLXDwd6I30ctkD8WQRYW+7a iAItjbvShjag== X-IronPort-AV: E=Sophos;i="5.81,222,1610438400"; d="scan'208";a="435790996" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2021 04:59:31 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lHnZg-009sbo-4n; Thu, 04 Mar 2021 14:59:28 +0200 Date: Thu, 4 Mar 2021 14:59:28 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Joel Becker , Christoph Hellwig , Shuah Khan , Linus Walleij , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Geert Uytterhoeven , Kent Gibson , Jonathan Corbet , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v2 06/12] lib: bitmap: order includes alphabetically Message-ID: References: <20210304102452.21726-1-brgl@bgdev.pl> <20210304102452.21726-7-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210304102452.21726-7-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 04, 2021 at 11:24:46AM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > For better readability and maintenance: order the includes in bitmap > source files alphabetically. Reviewed-by: Andy Shevchenko > Signed-off-by: Bartosz Golaszewski > --- > include/linux/bitmap.h | 4 ++-- > lib/bitmap.c | 9 +++++---- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h > index 6939a8983026..3282db97e06c 100644 > --- a/include/linux/bitmap.h > +++ b/include/linux/bitmap.h > @@ -4,10 +4,10 @@ > > #ifndef __ASSEMBLY__ > > -#include > #include > -#include > #include > +#include > +#include > > /* > * bitmaps provide bit arrays that consume one or more unsigned > diff --git a/lib/bitmap.c b/lib/bitmap.c > index 75006c4036e9..78f70d9007ad 100644 > --- a/lib/bitmap.c > +++ b/lib/bitmap.c > @@ -3,17 +3,18 @@ > * lib/bitmap.c > * Helper functions for bitmap.h. > */ > -#include > -#include > -#include > -#include > + > #include > #include > #include > +#include > +#include > +#include > #include > #include > #include > #include > +#include > #include > > #include > -- > 2.29.1 > -- With Best Regards, Andy Shevchenko