From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22446C433E0 for ; Sat, 6 Mar 2021 08:21:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1DA364FE4 for ; Sat, 6 Mar 2021 08:21:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230070AbhCFIVI (ORCPT ); Sat, 6 Mar 2021 03:21:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:54970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229701AbhCFIU4 (ORCPT ); Sat, 6 Mar 2021 03:20:56 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id AA45564FE4; Sat, 6 Mar 2021 08:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615018856; bh=V+apSkenj7wVNfvNTT/reRzRO7BIURwxpVzitvx2RuE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GkEt9F0qplk/H2xjRMgtaqKwa69fb2iYjAEeYNF0F7Q0F3/KK0/oVEm7Z5rCekMI5 hbBPgUaqq4jAn+HbHIphTac6jzv6hDufnElIrLygTgBl5JDj7jQkS5vJDLH5dn0ODW cIihiBS0ByovsR1lQpsGJVuKzdLcXMhNyKlNwlH0= Date: Sat, 6 Mar 2021 09:20:53 +0100 From: Greg KH To: nabil5352 Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: android: ashmem: fixed a struct without const Message-ID: References: <20210306063817.674041-1-nabil.ibn.mahmud@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210306063817.674041-1-nabil.ibn.mahmud@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 06, 2021 at 12:38:17PM +0600, nabil5352 wrote: > Fixed a struct without const > > Signed-off-by: nabil5352 > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > index d66a64e42273..7854fd410efa 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; > struct ashmem_area *asma = file->private_data; > int ret = 0; > It's a bit rude to submit patches that you have not at the very least, tried to build before sending it out to us, right? Please always do so. greg k-h