From: Tejun Heo <tj@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Xunlei Pang <xlpang@linux.alibaba.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-cgroup: Fix the recursive blkg rwstat
Date: Sun, 7 Mar 2021 07:42:10 -0500 [thread overview]
Message-ID: <YETKIo2iZpcd08Zk@slm.duckdns.org> (raw)
In-Reply-To: <4cc104d1-9aa3-a838-b786-9a808dd85945@kernel.dk>
On Fri, Mar 05, 2021 at 11:32:05AM -0700, Jens Axboe wrote:
> On 3/5/21 1:13 AM, Xunlei Pang wrote:
> > The current blkio.throttle.io_service_bytes_recursive doesn't
> > work correctly.
> >
> > As an example, for the following blkcg hierarchy:
> > (Made 1GB READ in test1, 512MB READ in test2)
> > test
> > / \
> > test1 test2
> >
> > $ head -n 1 test/test1/blkio.throttle.io_service_bytes_recursive
> > 8:0 Read 1073684480
> > $ head -n 1 test/test2/blkio.throttle.io_service_bytes_recursive
> > 8:0 Read 537448448
> > $ head -n 1 test/blkio.throttle.io_service_bytes_recursive
> > 8:0 Read 537448448
> >
> > Clearly, above data of "test" reflects "test2" not "test1"+"test2".
> >
> > Do the correct summary in blkg_rwstat_recursive_sum().
>
> LGTM, Tejun?
Gees, that's horrible. Thanks for fixing this.
Acked-by: Tejun Heo <tj@kernel.org>
--
tejun
prev parent reply other threads:[~2021-03-07 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1614932007-97224-1-git-send-email-xlpang@linux.alibaba.com>
2021-03-05 18:32 ` Jens Axboe
2021-03-07 12:42 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YETKIo2iZpcd08Zk@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xlpang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®