mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Selvakumar Elangovan <selvakumar16197@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: fixed whitespace coding style issue
Date: Tue, 9 Mar 2021 14:25:35 +0100	[thread overview]
Message-ID: <YEd3T9D3kMWTU+Pe@kroah.com> (raw)
In-Reply-To: <20210309125445.15167-1-selvakumar16197@gmail.com>

On Tue, Mar 09, 2021 at 06:24:45PM +0530, Selvakumar Elangovan wrote:
> Removed additional whitspaces and added space around the binary operator in the rtl8712_xmit.h file

Please wrap your changelog at 72 columns.

And you are doing 2 different things in this patch, please only do one
"logical" thing.

And finally, you sent 2 copies of this patch, I don't know which to
apply, so I'll drop both and wait for a v2.

thanks,

greg k-h

  reply	other threads:[~2021-03-09 13:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 12:54 Selvakumar Elangovan
2021-03-09 13:25 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-03-09 12:49 Selvakumar Elangovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEd3T9D3kMWTU+Pe@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=selvakumar16197@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®