From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F23AC4332E for ; Wed, 10 Mar 2021 12:45:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3720564FF6 for ; Wed, 10 Mar 2021 12:45:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232570AbhCJMpL (ORCPT ); Wed, 10 Mar 2021 07:45:11 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:33724 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231922AbhCJMpI (ORCPT ); Wed, 10 Mar 2021 07:45:08 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A23CCF3; Wed, 10 Mar 2021 13:45:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1615380306; bh=Hh/wbqpS2bI3vg2h7cXW9suyxITAoalNGEkviFTVRj4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OdoZM4/KyQEStBlvzCfFHADNxtRfp3wP5C/BnK0xJGlLEcjG3VXku4Q2iKfaIZbRL lgh7qlNJDtaAOOUlcAcqO2Wozpdve5vLa/msWLTFR77KIoe20xrI7V/6mspin/LwzZ EsuVoeaVdWJ5xTMKz0Qq84a67RMgZSk8+LC7KAHg= Date: Wed, 10 Mar 2021 14:44:33 +0200 From: Laurent Pinchart To: Lad Prabhakar Cc: Dave Stevenson , Mauro Carvalho Chehab , Pavel Machek , Andrey Konovalov , Sakari Ailus , Jacopo Mondi , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das Subject: Re: [PATCH 1/3] media: i2c: imx219: Enable vflip and hflip controls on stream stop Message-ID: References: <20210310122014.28353-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210310122014.28353-2-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210310122014.28353-2-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, Thank you for the patch. On Wed, Mar 10, 2021 at 12:20:12PM +0000, Lad Prabhakar wrote: > Enable vflip and hflip controls in resume error path when streaming > is stopped. > > Fixes: 1283b3b8f82b9 ("media: i2c: Add driver for Sony IMX219 sensor") > Reported-by: Pavel Machek > Signed-off-by: Lad Prabhakar > --- > drivers/media/i2c/imx219.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > index 6e3382b85a90..f0cf1985a4dc 100644 > --- a/drivers/media/i2c/imx219.c > +++ b/drivers/media/i2c/imx219.c > @@ -1195,6 +1195,8 @@ static int __maybe_unused imx219_resume(struct device *dev) > error: > imx219_stop_streaming(imx219); > imx219->streaming = false; > + __v4l2_ctrl_grab(imx219->vflip, false); > + __v4l2_ctrl_grab(imx219->hflip, false); It's not very nice to do this manually in imx219_resume(). Shouldn't we move the __v4l2_ctrl_grab() calls from imx219_set_stream() to imx219_start_streaming() and imx219_stop_streaming() instead ? > > return ret; > } -- Regards, Laurent Pinchart