From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67CC7C433E9 for ; Wed, 10 Mar 2021 12:50:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F3EA64FF4 for ; Wed, 10 Mar 2021 12:50:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232274AbhCJMt3 (ORCPT ); Wed, 10 Mar 2021 07:49:29 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:33770 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230341AbhCJMtX (ORCPT ); Wed, 10 Mar 2021 07:49:23 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D88C0F3; Wed, 10 Mar 2021 13:49:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1615380561; bh=PfudLm8IB8UcKwqnvgrPKNV/7E2BOCVn2FSW4I+2Yy0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iqesv+DcwzHjhsCvShM24On6+r7/w6NtllyuF0Ay6aKG1vYizwGwkk+LUX0rhwLx4 iMAhNqlxcTegyD2AJnar0T24BQbyL550uq4r+BXh6Ubpf0TRKHt45iHsCWn7UyPVeB vQu08wullLmN9CHRB1wEYiaFSQCK8QgPAfcEBsoc= Date: Wed, 10 Mar 2021 14:48:47 +0200 From: Laurent Pinchart To: Lad Prabhakar Cc: Dave Stevenson , Mauro Carvalho Chehab , Pavel Machek , Andrey Konovalov , Sakari Ailus , Jacopo Mondi , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das Subject: Re: [PATCH 3/3] media: i2c: imx219: Balance runtime PM use-count in resume callback Message-ID: References: <20210310122014.28353-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210310122014.28353-4-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210310122014.28353-4-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, Thank you for the patch. On Wed, Mar 10, 2021 at 12:20:14PM +0000, Lad Prabhakar wrote: > The runtime PM use-count gets incremented in imx219_set_stream() call > when streaming is started this needs to be balanced by calling > pm_runtime_put() upon failure to start stream in resume callback. > > Fixes: 1283b3b8f82b9 ("media: i2c: Add driver for Sony IMX219 sensor") > Reported-by: Pavel Machek > Signed-off-by: Lad Prabhakar > --- > drivers/media/i2c/imx219.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > index 87c021de1460..afffc85cd265 100644 > --- a/drivers/media/i2c/imx219.c > +++ b/drivers/media/i2c/imx219.c > @@ -1184,6 +1184,7 @@ static int __maybe_unused imx219_resume(struct device *dev) > { > struct v4l2_subdev *sd = dev_get_drvdata(dev); > struct imx219 *imx219 = to_imx219(sd); > + struct i2c_client *client; > int ret; > > mutex_lock(&imx219->mutex); > @@ -1197,7 +1198,9 @@ static int __maybe_unused imx219_resume(struct device *dev) > return 0; > > error: > + client = v4l2_get_subdevdata(&imx219->sd); > imx219_stop_streaming(imx219); > + pm_runtime_put(&client->dev); > imx219->streaming = false; > __v4l2_ctrl_grab(imx219->vflip, false); > __v4l2_ctrl_grab(imx219->hflip, false); Similarly to the __v4l2_ctrl_grab(), it could be better to move pm_runtime_put() to imx219_stop_streaming(). -- Regards, Laurent Pinchart