mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Shevchenko <andy@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v4 2/2] gpio: sch: Hook into ACPI SCI handler to catch GPIO edge events
Date: Wed, 17 Mar 2021 11:52:26 +0200	[thread overview]
Message-ID: <YFHRWm6YIh9NU1I/@smile.fi.intel.com> (raw)
In-Reply-To: <a3a6c80a-724c-e2fb-9597-b14a302c5ff4@siemens.com>

On Wed, Mar 17, 2021 at 07:57:44AM +0100, Jan Kiszka wrote:
> On 16.03.21 21:49, Andy Shevchenko wrote:
> > On Tue, Mar 16, 2021 at 06:26:13PM +0200, Andy Shevchenko wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> Neither the ACPI description on the Quark platform provides the required
> >> information is to do establish generic handling nor hardware capable of
> >> doing it. According to the datasheet the hardware can generate SCI events.
> >> Therefore, we need to hook from the driver directly into SCI handler of
> >> the ACPI subsystem in order to catch and report GPIO-related events.
> >>
> >> Validated on the Quark-based IOT2000 platform.
> > 
> > This patch must be dropped completely. SCI handler is not correct way to do
> > this. The proper way (and we have already few examples in the kernel) is to
> > register GPE event.
> 
> As explained above, this is not supported by the preexisting firmware,
> and there won't be any updates to it anymore.
> 
> This platform is history, the SoC was discontinued by Intel long ago,
> and our devices reaching their support end as well. The race to upstream
> was lost in this case - backlog too long, we being too slow.

So you have no device to test and there is actually no device which has this
capability in the wild.

Am I reading this correct?

In any case, we have platforms in the wild that actually support GPEs and this
makes sense for them.

> > It took me a while to gather all bits of this puzzle.
> > 
> > At least now I get an event, but kernel oopses, I'll continue debugging
> > tomorrow.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2021-03-17  9:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 16:26 [PATCH v4 0/2] gpio: sch: Interrupt support Andy Shevchenko
2021-03-16 16:26 ` [PATCH v4 1/2] gpio: sch: Add edge event support Andy Shevchenko
2021-03-16 16:26 ` [PATCH v4 2/2] gpio: sch: Hook into ACPI SCI handler to catch GPIO edge events Andy Shevchenko
2021-03-16 17:05   ` Andy Shevchenko
2021-03-16 20:49   ` Andy Shevchenko
2021-03-17  6:57     ` Jan Kiszka
2021-03-17  9:52       ` Andy Shevchenko [this message]
2021-03-17  9:57         ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFHRWm6YIh9NU1I/@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=jan.kiszka@siemens.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®