From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3A37C433DB for ; Thu, 18 Mar 2021 16:40:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B07F064F2A for ; Thu, 18 Mar 2021 16:40:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232173AbhCRQkY (ORCPT ); Thu, 18 Mar 2021 12:40:24 -0400 Received: from zeniv-ca.linux.org.uk ([142.44.231.140]:38800 "EHLO zeniv-ca.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231833AbhCRQkQ (ORCPT ); Thu, 18 Mar 2021 12:40:16 -0400 Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94 #2 (Red Hat Linux)) id 1lMvcU-0079z0-3A; Thu, 18 Mar 2021 16:35:34 +0000 Date: Thu, 18 Mar 2021 16:35:34 +0000 From: Al Viro To: Matthew Wilcox Cc: Xiaofeng Cao , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Xiaofeng Cao Subject: Re: [PATCH] fs/dcache: fix typos and sentence disorder Message-ID: References: <20210318143153.13455-1-caoxiaofeng@yulong.com> <20210318150020.GP3420@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210318150020.GP3420@casper.infradead.org> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 18, 2021 at 03:00:20PM +0000, Matthew Wilcox wrote: > On Thu, Mar 18, 2021 at 10:31:53PM +0800, Xiaofeng Cao wrote: > > change 'sould' to 'should' > > change 'colocated' to 'collocated' > > uh. collocated is incorrect. colocated is correct. > https://www.merriam-webster.com/dictionary/colocate > https://www.merriam-webster.com/dictionary/collocate A bit more condensed variant: these two are both derived from con- + loco, but have different meanings - colocated: occupying the same place collocated: sitting next to each other In this case it's very much the former - the point of comment is that the fields in question share the same memory location, but we are guaranteed that any dentry we find in the alias list of an inode will have that location used for ->i_dentry. "co-located" would probably work better there. PS: history of that word pair is amusing. Both are (English) past participles, of co-locate and collocate resp. The former had the (Latin) prefix applied in English to borrowing from Latin (co-locate < locate < locatus) , the latter is straight borrowing (collocate < collocatus). Incidentally, in both cases the borrowed form had already been a past participle (of loco and colloco) resp. And colloco had the same prefix (com-/con-/co-) applied in Latin, with regular assimilation of -nl- to -ll-. But at that stage the meaning of the verb had been closer to "put in place" than to "be in place", so that gave "put next to each other" instead of "share the place". Shift towards "be found next to each other" happened long after the prefix had been applied...