From: Tejun Heo <tj@kernel.org>
To: Wang Qing <wangqing@vivo.com>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Guilherme G. Piccoli" <gpiccoli@canonical.com>,
Andrey Ignatov <rdna@fb.com>, Vlastimil Babka <vbabka@suse.cz>,
Petr Mladek <pmladek@suse.com>,
Santosh Sivaraj <santosh@fossix.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] workqueue: watchdog: update wq_watchdog_touched for unbound lockup checking
Date: Sat, 20 Mar 2021 14:20:46 -0400 [thread overview]
Message-ID: <YFY8/u0Bmf8TpJTS@slm.duckdns.org> (raw)
In-Reply-To: <1616140838-24222-1-git-send-email-wangqing@vivo.com>
On Fri, Mar 19, 2021 at 04:00:36PM +0800, Wang Qing wrote:
> When touch_softlockup_watchdog() is called, only wq_watchdog_touched_cpu
> updated, while the unbound worker_pool running on its core uses
> wq_watchdog_touched to determine whether locked up. This may be mischecked.
Can you please elaborate here, preferably with a concrete scenario where the
new code is better?
Thanks.
--
tejun
next prev parent reply other threads:[~2021-03-20 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 8:00 Wang Qing
2021-03-20 18:20 ` Tejun Heo [this message]
2021-03-22 1:47 ` 王擎
2021-03-22 10:59 ` Petr Mladek
2021-03-23 12:37 ` 王擎
2021-03-23 15:06 ` Petr Mladek
2021-03-24 2:16 ` 王擎
2021-03-24 8:50 ` Petr Mladek
2021-03-24 9:42 ` 王擎
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFY8/u0Bmf8TpJTS@slm.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gpiccoli@canonical.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rdna@fb.com \
--cc=santosh@fossix.org \
--cc=vbabka@suse.cz \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®