From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A514C433E1 for ; Mon, 22 Mar 2021 16:08:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E092F619B7 for ; Mon, 22 Mar 2021 16:08:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231676AbhCVQIc (ORCPT ); Mon, 22 Mar 2021 12:08:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:54920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231270AbhCVQIA (ORCPT ); Mon, 22 Mar 2021 12:08:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 15E07619B8; Mon, 22 Mar 2021 16:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616429276; bh=bqoeuGuZHclyiqqImlv9B3+pvikM/T3tAXBfmPztMmQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D47G+25pfVObiOEQ9qddeviFeBgdbM0QJ28BZQPfmBDcUqRub5fih46R6ccse/DhD ukLw9iCqatyUK7H1y1+JzPJk+90NrXApke0bibWlcjXNSb8C7a+nEC1a2IPLiFg/F4 XW+CM0GdI3XR9de/ITa6TVeYOXmRWg6Lom+L9M0A= Date: Mon, 22 Mar 2021 17:07:53 +0100 From: Greg KH To: Fabio Aiuto Cc: joe@perches.com, apw@canonical.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/11] staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote: > fix the following checkpatch issues: > > WARNING: externs should be avoided in .c files > 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35: > +bool > > moved two function prototypes in include/rtw_efuse.h > > Signed-off-by: Fabio Aiuto > --- > drivers/staging/rtl8723bs/core/rtw_efuse.c | 10 ---------- > drivers/staging/rtl8723bs/include/rtw_efuse.h | 3 +++ > 2 files changed, 3 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c > index 32ca10f01413..0772397738d4 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c > +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c > @@ -32,11 +32,6 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0}; > #define REG_EFUSE_CTRL 0x0030 > #define EFUSE_CTRL REG_EFUSE_CTRL /* E-Fuse Control. */ > > -bool > -Efuse_Read1ByteFromFakeContent( > - struct adapter *padapter, > - u16 Offset, > - u8 *Value); > bool > Efuse_Read1ByteFromFakeContent( > struct adapter *padapter, > @@ -53,11 +48,6 @@ Efuse_Read1ByteFromFakeContent( > return true; > } > > -bool > -Efuse_Write1ByteToFakeContent( > - struct adapter *padapter, > - u16 Offset, > - u8 Value); > bool > Efuse_Write1ByteToFakeContent( > struct adapter *padapter, > diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h > index 5bae46ecd9de..1f304df8c421 100644 > --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h > +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h > @@ -103,6 +103,9 @@ extern u8 fakeBTEfuseInitMap[]; > extern u8 fakeBTEfuseModifiedMap[]; > /*------------------------Export global variable----------------------------*/ > > +bool Efuse_Read1ByteFromFakeContent(struct adapter *padapter, u16 Offset, u8 *Value); > +bool Efuse_Write1ByteToFakeContent(struct adapter *padapter, u16 Offset, u8 Value); No, there's no need for this to be in a .h file, it is only called from one .c file. Make the thing static and all should be fine, right? thanks, greg k-h