From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Tomi Valkeinen <tomba@kernel.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Jyri Sarha <jsarha@ti.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kael_w@yeah.net
Subject: Re: [PATCH] drivers: gpu: drm: Remove duplicate declaration
Date: Thu, 25 Mar 2021 11:04:39 +0200 [thread overview]
Message-ID: <YFxSJ/EQWilHfT51@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210325045022.847135-1-wanjiabing@vivo.com>
Hi Wan,
Thank you for the patch.
On Thu, Mar 25, 2021 at 12:50:19PM +0800, Wan Jiabing wrote:
> struct dss_device has been declared at 51st line.
> Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> index a40abeafd2e9..2658aadee09a 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -52,7 +52,6 @@ struct dss_device;
> struct omap_drm_private;
> struct omap_dss_device;
> struct dispc_device;
> -struct dss_device;
> struct dss_lcd_mgr_config;
> struct snd_aes_iec958;
> struct snd_cea_861_aud_if;
While at it, could you sort these forward declarations alphabetically,
so that duplicates are easier to see ?
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2021-03-25 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 4:50 Wan Jiabing
2021-03-25 9:04 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFxSJ/EQWilHfT51@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=tomba@kernel.org \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®