From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9E0FC433DB for ; Thu, 25 Mar 2021 13:22:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97EA261A23 for ; Thu, 25 Mar 2021 13:22:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230252AbhCYNVj (ORCPT ); Thu, 25 Mar 2021 09:21:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:55852 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230239AbhCYNVW (ORCPT ); Thu, 25 Mar 2021 09:21:22 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B723DAC16; Thu, 25 Mar 2021 13:21:21 +0000 (UTC) Date: Thu, 25 Mar 2021 14:21:19 +0100 From: Oscar Salvador To: Wang Wensheng Cc: akpm@linux-foundation.org, pasha.tatashin@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rui.xiang@huawei.com Subject: Re: [PATCH] mm/sparse: Add the missing sparse_buffer_fini() in error branch Message-ID: References: <20210325113155.118574-1-wangwensheng4@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325113155.118574-1-wangwensheng4@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 25, 2021 at 11:31:55AM +0000, Wang Wensheng wrote: > sparse_buffer_init() and sparse_buffer_fini() should appear in pair, or > a WARN issue would be through the next time sparse_buffer_init() runs. > > Add the missing sparse_buffer_fini() in error branch. > > Fixes: 85c77f791390 ("mm/sparse: add new sparse_init_nid() and sparse_init()") > Signed-off-by: Wang Wensheng Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3