From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Petr Mladek <pmladek@suse.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, kael_w@yeah.net
Subject: Re: [PATCH] include: linux: debug_locks: Remove duplicate declaration
Date: Thu, 25 Mar 2021 15:22:22 +0200 [thread overview]
Message-ID: <YFyOjtTI8XXPKgph@smile.fi.intel.com> (raw)
In-Reply-To: <20210325022707.840531-1-wanjiabing@vivo.com>
On Thu, Mar 25, 2021 at 10:26:58AM +0800, Wan Jiabing wrote:
> struct task_struct is declared at 9th line. Remove the duplicate.
It seems the duplicate is the other one and you removed wrong one.
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> include/linux/debug_locks.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
> index 2915f56ad421..0b3187a5290d 100644
> --- a/include/linux/debug_locks.h
> +++ b/include/linux/debug_locks.h
> @@ -46,7 +46,6 @@ extern int debug_locks_off(void);
> # define locking_selftest() do { } while (0)
> #endif
>
> -struct task_struct;
>
> #ifdef CONFIG_LOCKDEP
> extern void debug_show_all_locks(void);
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-25 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 2:26 Wan Jiabing
2021-03-25 13:22 ` Andy Shevchenko [this message]
2021-03-25 13:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFyOjtTI8XXPKgph@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®