From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Daniel Gomez <daniel@qtec.com>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: designware: Add base addr info
Date: Thu, 25 Mar 2021 17:43:03 +0200 [thread overview]
Message-ID: <YFyvh3sqyVcg8Iqj@smile.fi.intel.com> (raw)
In-Reply-To: <20210325151248.1066643-1-daniel@qtec.com>
On Thu, Mar 25, 2021 at 04:12:48PM +0100, Daniel Gomez wrote:
> Add i2c hw base address in the adapter name and when the device is
> probed.
Why?
We have /proc/iomem for that.
Sorry, I don't see value of this change.
Some comments below just to let you know about style:ish issues.
...
> snprintf(adap->name, sizeof(adap->name),
> - "Synopsys DesignWare I2C adapter");
> + "Synopsys DesignWare I2C adapter at 0x%llx", dev->base_addr);
It actually should be resource_size_t and corresponding specifier, i.e. %pa to
print it. Moreover, we have %pR (and %pr) specifiers for struct resource.
...
> + dev_info(&pdev->dev, "%s\n", adap->name);
Unneeded noise.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-25 15:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 15:12 Daniel Gomez
2021-03-25 15:43 ` Andy Shevchenko [this message]
2021-03-26 10:35 ` Daniel Gomez
2021-03-26 12:28 ` Andy Shevchenko
2021-03-27 18:15 ` Daniel Gomez
2021-03-27 19:03 ` Andy Shevchenko
2021-03-26 1:50 ` kernel test robot
2021-03-29 15:59 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFyvh3sqyVcg8Iqj@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=daniel@qtec.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®