From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B383FC433C1 for ; Thu, 25 Mar 2021 15:46:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7715361A2B for ; Thu, 25 Mar 2021 15:46:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231571AbhCYPpm (ORCPT ); Thu, 25 Mar 2021 11:45:42 -0400 Received: from mga17.intel.com ([192.55.52.151]:47365 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230438AbhCYPp2 (ORCPT ); Thu, 25 Mar 2021 11:45:28 -0400 IronPort-SDR: tG+4mCt7J1sTW+lgdOhftp0pcJdgGMBJPaJ4EZdTRupbv1diSMm2SROBadJWFdpwLRWNDYUNOZ IuY8gtoiSsWQ== X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="170935033" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="170935033" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 08:45:27 -0700 IronPort-SDR: ttG/+1rrifuWhY0jX+aAvXNx2TuCEsyyqCIVmF5ZKXHeqfuWGEPKhR8LYcFUl1vY9V7ZthoyEb uS9EuJOkhSKg== X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="525695283" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 08:45:25 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lPSAk-00G5au-EU; Thu, 25 Mar 2021 17:45:22 +0200 Date: Thu, 25 Mar 2021 17:45:22 +0200 From: Andy Shevchenko To: Wan Jiabing Cc: Thomas Gleixner , Peter Zijlstra , Sergey Senozhatsky , linux-kernel@vger.kernel.org, keal_w@yeah.net Subject: Re: [PATCH] [v2] include: linux: debug_locks: Remove duplicate declaration Message-ID: References: <20210325152029.4976-1-wanjiabing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325152029.4976-1-wanjiabing@vivo.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 25, 2021 at 11:20:28PM +0800, Wan Jiabing wrote: > struct task_struct has been declared. "...declared twice." In the subject line the "include: linux: " part is not needed. FWIW, after addressing above, Reviewed-by: Andy Shevchenko > Remove the duplicate. > > Signed-off-by: Wan Jiabing > --- > Changelog: > v2: > - Remove another duplicate declaration for being closer > to its user. > --- > include/linux/debug_locks.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h > index 2915f56ad421..32f6a37a3d3f 100644 > --- a/include/linux/debug_locks.h > +++ b/include/linux/debug_locks.h > @@ -6,8 +6,6 @@ > #include > #include > > -struct task_struct; > - > extern int debug_locks __read_mostly; > extern int debug_locks_silent __read_mostly; > > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko