From: Greg KH <gregkh@linuxfoundation.org>
To: Mitali Borkar <mitaliborkar810@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com, mitali_s@me.iitr.ac.in
Subject: Re: [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h
Date: Wed, 7 Apr 2021 10:05:28 +0200 [thread overview]
Message-ID: <YG1nyA3ZJbEzVNDu@kroah.com> (raw)
In-Reply-To: <YG1l6QIKRMjqgPiD@kali>
On Wed, Apr 07, 2021 at 01:27:29PM +0530, Mitali Borkar wrote:
> Fixed Check:Avoid CamelCase by renaming SetFilter to set_filter
> Reported by checkpatch.
>
> Signed-off-by: Mitali Borkar <mitaliborkar810@example.com>
> ---
> drivers/staging/rtl8712/xmit_osdep.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/xmit_osdep.h b/drivers/staging/rtl8712/xmit_osdep.h
> index b76021b568f8..7ad2ac6f5ff0 100644
> --- a/drivers/staging/rtl8712/xmit_osdep.h
> +++ b/drivers/staging/rtl8712/xmit_osdep.h
> @@ -35,7 +35,7 @@ struct xmit_frame;
> struct xmit_buf;
>
> int r8712_xmit_entry(_pkt *pkt, struct net_device *pnetdev);
> -void r8712_SetFilter(struct work_struct *work);
> +void r8712_set_filter(struct work_struct *work);
> int r8712_xmit_resource_alloc(struct _adapter *padapter,
> struct xmit_buf *pxmitbuf);
> void r8712_xmit_resource_free(struct _adapter *padapter,
> --
> 2.30.2
>
>
Did you try test-building your change? Always do so :(
next prev parent reply other threads:[~2021-04-07 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 7:57 Mitali Borkar
2021-04-07 8:05 ` Greg KH [this message]
2021-04-07 10:45 ` kernel test robot
2021-04-07 16:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG1nyA3ZJbEzVNDu@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mitali_s@me.iitr.ac.in \
--cc=mitaliborkar810@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®