mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fenghua Yu <fenghua.yu@intel.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Shuah Khan <shuah@kernel.org>,
	Ravi V Shankar <ravi.v.shankar@intel.com>,
	linux-kselftest <linux-kselftest@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/resctrl: Change a few printed messages
Date: Wed, 7 Apr 2021 17:12:14 +0000	[thread overview]
Message-ID: <YG3n7gsIhqOGjltv@otcwcpicx3.sc.intel.com> (raw)
In-Reply-To: <67062f6c-d09a-f8e0-4d22-49c4452d0552@linuxfoundation.org>

Hi, Shuah,

On Wed, Apr 07, 2021 at 08:33:23AM -0600, Shuah Khan wrote:
> On 4/5/21 6:52 PM, Fenghua Yu wrote:
> > -	ksft_print_msg("%s cache miss rate within %d%%\n",
> > -		       ret ? "Fail:" : "Pass:", max_diff_percent);
> > +	ksft_print_msg("Check cache miss rate within %d%%\n", max_diff_percent);
> 
> You need %s and pass in the ret ? "Fail:" : "Pass:" result for the
> message to read correctly.

Should I keep the ":" after "Pass"/"Fail"?

> 
> I am seeing:
> 
> # Check kernel support for resctrl filesystem
> 
> It should say the following:
> 
> # Fail Check kernel support for resctrl filesystem

i.e. should the printed messages be like the following?
# Fail: Check kernel support for resctrl filesystem
or
# Pass: Check kernel support for resctrl filesystem

Thanks.

-Fenghua

  reply	other threads:[~2021-04-07 17:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06  0:52 Fenghua Yu
2021-04-07 14:33 ` Shuah Khan
2021-04-07 17:12   ` Fenghua Yu [this message]
2021-04-07 18:15     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YG3n7gsIhqOGjltv@otcwcpicx3.sc.intel.com \
    --to=fenghua.yu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®