mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Min Li <min.li.xe@renesas.com>
Cc: "derek.kiernan@xilinx.com" <derek.kiernan@xilinx.com>,
	"dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support
Date: Thu, 8 Apr 2021 08:20:38 +0200	[thread overview]
Message-ID: <YG6gtoOtqJSv63fg@kroah.com> (raw)
In-Reply-To: <OSBPR01MB4773A83DF7D1CDA4DBFD9E84BA759@OSBPR01MB4773.jpnprd01.prod.outlook.com>

On Wed, Apr 07, 2021 at 08:00:38PM +0000, Min Li wrote:
> > 
> > Do you really meen "+" here?  (sorry, have to ask.)
> > 
> 
> I don't know. All of our Linux kernel code has GPL-2.0+ and I just blindly inherit it.

You should ask your managers :)

> 
> > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > 
> > You should not need this as it's a driver, so you should only use the
> > dev_dbg() family of print message functions, no need for pr_*() calls.
> > 
> I have one call to pr_err in rsmu_init
> 
> pr_err("Unabled to register %s platform driver", DRIVER_NAME); 
> 

My recommendation in another email shows that the line above is not
needed...

thanks,

greg k-h

  reply	other threads:[~2021-04-08  6:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 17:33 [PATCH net-next v2 1/2] mfd: " min.li.xe
2021-04-07 17:33 ` [PATCH net-next v2 2/2] misc: " min.li.xe
2021-04-07 17:45   ` Greg KH
2021-04-07 19:43     ` Min Li
2021-04-08  6:19       ` Greg KH
2021-04-08 19:40         ` Min Li
2021-04-07 17:47   ` Greg KH
2021-04-07 20:00     ` Min Li
2021-04-08  6:20       ` Greg KH [this message]
2021-04-07 17:48   ` Greg KH
2021-04-07 19:56     ` Min Li
2021-04-07 17:51   ` Greg KH
2021-04-07 20:12     ` Min Li
2021-04-08  6:36       ` Greg KH
2021-04-08 17:36         ` Min Li
2021-04-07 17:34 [PATCH net-next v2 1/2] mfd: " min.li.xe
2021-04-07 17:34 ` [PATCH net-next v2 2/2] misc: " min.li.xe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YG6gtoOtqJSv63fg@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=derek.kiernan@xilinx.com \
    --cc=dragan.cvetic@xilinx.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=min.li.xe@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®