From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Syed Nayyar Waris <syednwaris@gmail.com>
Cc: bgolaszewski@baylibre.com, vilhelm.gray@gmail.com,
michal.simek@xilinx.com, arnd@arndb.de, rrichter@marvell.com,
linus.walleij@linaro.org, yamada.masahiro@socionext.com,
akpm@linux-foundation.org, rui.zhang@intel.com,
daniel.lezcano@linaro.org, amit.kucheria@verdurent.com,
linux-arch@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [RESEND PATCH v4 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value
Date: Thu, 8 Apr 2021 16:44:01 +0300 [thread overview]
Message-ID: <YG8IoWznJEzwfigA@smile.fi.intel.com> (raw)
In-Reply-To: <d150bd18acc767c86c23ec06cc2abd5ca74ccbbb.1617380819.git.syednwaris@gmail.com>
On Fri, Apr 02, 2021 at 10:07:36PM +0530, Syed Nayyar Waris wrote:
> This patch reimplements the xgpio_set_multiple() function in
> drivers/gpio/gpio-xilinx.c to use the new generic functions:
> bitmap_get_value() and bitmap_set_value(). The code is now simpler
> to read and understand. Moreover, instead of looping for each bit
> in xgpio_set_multiple() function, now we can check each channel at
> a time and save cycles.
As promised, I have looked at this with a fresh eye and NAK from me. Sorry.
This is less than a half baked solution. I spent couple of evenings, so
I'll come up with full conversion of this driver to the bitmap API.
And yes, as I have told you like half a year before, bitmap_get_value32() and
bitmap_set_value32() is much more useful (and I actually implemented them
locally for the sake of conversion).
So, summarize this I do not think we have real users of the proposed API.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-04-08 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 16:35 [RESEND PATCH v4 0/3] Introduce the for_each_set_nbits macro Syed Nayyar Waris
2021-04-02 16:36 ` [RESEND PATCH v4 1/3] gpiolib: " Syed Nayyar Waris
2021-04-02 16:36 ` [RESEND PATCH v4 2/3] gpio: thunderx: Utilize " Syed Nayyar Waris
2021-04-02 16:37 ` [RESEND PATCH v4 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value Syed Nayyar Waris
2021-04-08 13:44 ` Andy Shevchenko [this message]
2021-04-02 17:30 ` [RESEND PATCH v4 0/3] Introduce the for_each_set_nbits macro Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG8IoWznJEzwfigA@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=amit.kucheria@verdurent.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=rrichter@marvell.com \
--cc=rui.zhang@intel.com \
--cc=syednwaris@gmail.com \
--cc=vilhelm.gray@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®