From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8FFAC433E4 for ; Sun, 28 Mar 2021 12:09:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C5E86196F for ; Sun, 28 Mar 2021 12:09:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231318AbhC1MJJ (ORCPT ); Sun, 28 Mar 2021 08:09:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:44658 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhC1MIr (ORCPT ); Sun, 28 Mar 2021 08:08:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 14DA160232; Sun, 28 Mar 2021 12:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616933324; bh=XtGZd3bNPgaiElFYXcnf/Q4Cl7Hd4Zr72qj0OGHshHc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kloGpqS8f+lUXnoy68FFx4ShbX17+KVIjoxKaDPIHU/MTk+b4ZvfRX/gRHj+UmEFR vWsZrfZRndy1YBpihWnTX9THblMlWEjMtLutIkpZK/GyDesLONhn5emot4DQ6qmzjK BkRk/zhorWnu992x9+/gr72f7HdjmmI3cG1oD4yI= Date: Sun, 28 Mar 2021 14:08:41 +0200 From: Greg KH To: Fabio Aiuto Cc: dan.carpenter@oracle.com, david.laight@aculab.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 09/20] staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_debug.h Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 27, 2021 at 03:24:08PM +0100, Fabio Aiuto wrote: > fix the following checkpatch warning: > > ERROR: Macros starting with if should be enclosed by a > do - while loop to avoid possible if/else logic defects > + #define RT_PRINT_DATA(_Comp, _Level, > _TitleString, _HexData, _HexDataLen) \ > > Signed-off-by: Fabio Aiuto > --- > drivers/staging/rtl8723bs/include/rtw_debug.h | 28 ++++++++++--------- > 1 file changed, 15 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h b/drivers/staging/rtl8723bs/include/rtw_debug.h > index d1c557818305..b00f8a6c4312 100644 > --- a/drivers/staging/rtl8723bs/include/rtw_debug.h > +++ b/drivers/staging/rtl8723bs/include/rtw_debug.h > @@ -236,19 +236,21 @@ > #if defined(_dbgdump) > #undef RT_PRINT_DATA > #define RT_PRINT_DATA(_Comp, _Level, _TitleString, _HexData, _HexDataLen) \ > - if (((_Comp) & GlobalDebugComponents) && (_Level <= GlobalDebugLevel)) \ > - { \ > - int __i; \ > - u8 *ptr = (u8 *)_HexData; \ > - _dbgdump("%s", DRIVER_PREFIX); \ > - _dbgdump(_TitleString); \ > - for (__i = 0; __i < (int)_HexDataLen; __i++) \ > - { \ > - _dbgdump("%02X%s", ptr[__i], (((__i + 1) % 4) == 0)?" ":" "); \ > - if (((__i + 1) % 16) == 0) _dbgdump("\n"); \ > - } \ > - _dbgdump("\n"); \ > - } This whole nightmare needs to just be deleted and any callers of it need to use the in-kernel functions for this instead. thanks, greg k-h