From: Vinod Koul <vkoul@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: yung-chuan.liao@linux.intel.com,
pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 6/9] soundwire: qcom: add support to new interrupts
Date: Tue, 30 Mar 2021 14:13:04 +0530 [thread overview]
Message-ID: <YGLkmM4QCjkpg8/6@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20210326063944.31683-7-srinivas.kandagatla@linaro.org>
On 26-03-21, 06:39, Srinivas Kandagatla wrote:
> - ctrl->reg_write(ctrl, SWRM_INTERRUPT_CLEAR, sts);
> + do {
> + for (i = 0; i < SWRM_INTERRUPT_MAX; i++) {
> + value = intr_sts_masked & (1 << i);
BIT(i) istead of shifiting?
> + if (!value)
> + continue;
> +
> + switch (value) {
> + case SWRM_INTERRUPT_STATUS_SLAVE_PEND_IRQ:
> + devnum = qcom_swrm_get_alert_slave_dev_num(swrm);
> + if (devnum < 0) {
> + dev_err_ratelimited(swrm->dev,
> + "no slave alert found.spurious interrupt\n");
> + } else {
> + sdw_handle_slave_status(&swrm->bus, swrm->status);
> + }
>
> - if (sts & SWRM_INTERRUPT_STATUS_SPECIAL_CMD_ID_FINISHED)
> - complete(&ctrl->broadcast);
> + break;
> + case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED:
> + case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS:
> + dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n",
> + __func__);
This should be debug
--
~Vinod
next prev parent reply other threads:[~2021-03-30 8:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 6:39 [PATCH v5 0/9] soundwire: qcom: various improvements Srinivas Kandagatla
2021-03-26 6:39 ` [PATCH v5 1/9] dt-bindings: soundwire: qcom: clarify data port bus parameters Srinivas Kandagatla
2021-03-26 6:39 ` [PATCH v5 2/9] soundwire: qcom: add support to missing transport params Srinivas Kandagatla
2021-03-26 6:39 ` [PATCH v5 3/9] soundwire: qcom: set continue execution flag for ignored commands Srinivas Kandagatla
2021-03-26 6:39 ` [PATCH v5 4/9] soundwire: qcom: start the clock during initialization Srinivas Kandagatla
2021-03-26 6:39 ` [PATCH v5 5/9] soundwire: qcom: update register read/write routine Srinivas Kandagatla
2021-03-30 8:40 ` Vinod Koul
2021-03-26 6:39 ` [PATCH v5 6/9] soundwire: qcom: add support to new interrupts Srinivas Kandagatla
2021-03-30 8:43 ` Vinod Koul [this message]
2021-03-26 6:39 ` [PATCH v5 7/9] soundwire: export sdw_compare_devid, sdw_extract_slave_id and sdw_slave_add Srinivas Kandagatla
2021-03-26 6:39 ` [PATCH v5 8/9] soundwire: qcom: add auto enumeration support Srinivas Kandagatla
2021-03-26 6:39 ` [PATCH v5 9/9] soundwire: qcom: wait for enumeration to be complete in probe Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGLkmM4QCjkpg8/6@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh@kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®