From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC06C43460 for ; Mon, 5 Apr 2021 10:15:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A741613B1 for ; Mon, 5 Apr 2021 10:15:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241684AbhDEKPO (ORCPT ); Mon, 5 Apr 2021 06:15:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:51372 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241211AbhDEKPO (ORCPT ); Mon, 5 Apr 2021 06:15:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 480F86128A; Mon, 5 Apr 2021 10:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617617706; bh=P8lomj32o8yraY8npLXMx485HIZmeqshrSBgIy6QGmQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ze4plzDZcyvsSmX37TMYpWoB2DcYw9pOymwTO62bUPK2+hdWX9W5W3DXhyLWeT8iu IgdAFSmLMplv/3Q9ELUbWy07Pvg2fbcKnXjDeVF1HPQGtmO0ueDkHHI08aFsupm4h6 ddRh39Q5O7BXalb7gM1IRwBeG45FmXMBSehD2U00= Date: Mon, 5 Apr 2021 12:15:04 +0200 From: Greg KH To: dev.dragon@bk.ru Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtl8192u: ieee80211: fixed a trailing statements of condition. Message-ID: References: <20210404132613.5464-1-dev.dragon@bk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210404132613.5464-1-dev.dragon@bk.ru> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 04, 2021 at 04:26:14PM +0300, dev.dragon@bk.ru wrote: > From: Dmitrii Wolf > > Fixed a coding style issue. Really? > > Signed-off-by: Dmitrii Wolf > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > index 690b664df8fa..29a6ce20e2bd 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > @@ -2048,12 +2048,12 @@ void ieee80211_softmac_xmit(struct ieee80211_txb *txb, struct ieee80211_device * > /* if xmit available, just xmit it immediately, else just insert it to the wait queue */ > for (i = 0; i < txb->nr_frags; i++) { > #ifdef USB_TX_DRIVER_AGGREGATION_ENABLE > - if ((skb_queue_len(&ieee->skb_drv_aggQ[queue_index]) != 0) || > + if ((skb_queue_len(&ieee->skb_drv_aggQ[queue_index]) != 0) > #else > - if ((skb_queue_len(&ieee->skb_waitQ[queue_index]) != 0) || > + if ((skb_queue_len(&ieee->skb_waitQ[queue_index]) != 0) > #endif > - (!ieee->check_nic_enough_desc(ieee->dev, queue_index)) || \ > - (ieee->queue_stop)) { > + || (!ieee->check_nic_enough_desc(ieee->dev, queue_index)) \ > + || (ieee->queue_stop)) { This feels really wrong. The || should be on the end of the line, why is checkpatch complaining about this? And that '\' is not needed at all :( thanks, greg k-h