From: Greg KH <gregkh@linuxfoundation.org>
To: Luiz Sampaio <sampaio.ime@gmail.com>
Cc: zbr@lwn.net, rikard.falkeborn@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 9/9] w1: ds2438: support for writing to offset register
Date: Mon, 5 Apr 2021 14:50:32 +0200 [thread overview]
Message-ID: <YGsHmCkHj6SwUqhD@kroah.com> (raw)
In-Reply-To: <20210405124401.mvkoxs2girygv7f2@LuizSampaio-PC.localdomain>
On Mon, Apr 05, 2021 at 09:44:01AM -0300, Luiz Sampaio wrote:
> On Mon, Apr 05, 2021 at 01:04:59PM +0200, Greg KH wrote:
> > On Mon, Apr 05, 2021 at 07:50:09AM -0300, Luiz Sampaio wrote:
> > > Added a sysfs entry to support writing to the offset register on page1.
> > > This register is used to calibrate the chip canceling offset errors in the
> > > current ADC. This means that, over time, reading the IAD register will not
> > > return the correct current measurement, it will have an offset. Writing to
> > > the offset register if the two's complement of the current register while
> > > passing zero current to the load will calibrate the measurements. This
> > > change was tested on real hardware and it was able to calibrate the chip
> > > correctly.
> > >
> > > Signed-off-by: Luiz Sampaio <sampaio.ime@gmail.com>
> > > ---
> > > Documentation/w1/slaves/w1_ds2438.rst | 11 +++++-
> > > drivers/w1/slaves/w1_ds2438.c | 49 +++++++++++++++++++++++++++
> > > 2 files changed, 59 insertions(+), 1 deletion(-)
> >
> > In this, and the previous patch, you added new sysfs files, but no
> > update to Documentation/ABI/ for them. Please fix that up.
> >
> > thanks,
> >
> > greg k-h
>
> Hello! I'm sorry about some errors, this is my first patch and I'm not sure about some things in the documentation. I really appreciate the responses and guidance.
No problem, again you should try wrapping your email lines :)
> The file I need to add to Documentation/ABI/ is going to be in testing or stable? And the file I need to create can be called, for instance, sysfs-driver-w1_ds2438?
stable I guess as you know this is what you want to do.
And the file name seems right, thanks.
greg k-h
next prev parent reply other threads:[~2021-04-05 12:50 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 1:24 [PATCH v2 0/9] w1: ds2438: adding support for calibration of current measurements Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 1/9] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 2/9] " Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 3/9] " Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 4/9] " Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 5/9] " Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 6/9] " Luiz Sampaio
2021-04-03 3:16 ` kernel test robot
2021-04-03 3:29 ` kernel test robot
2021-04-03 1:24 ` [PATCH v2 7/9] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 8/9] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 9/9] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-03 4:45 ` [PATCH v3 0/9] w1: ds2438: adding support for calibration of current measurements Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 1/9] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 2/9] " Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 3/9] " Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 4/9] " Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 5/9] " Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 6/9] " Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 7/9] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 8/9] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 9/9] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 0/9] w1: ds2438: adding support for calibration of current measurements Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 1/9] w1: ds2438: fixed a coding style issue after return Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 2/9] w1: ds2438: fixed a coding style issue in iad_read Luiz Sampaio
2021-04-05 10:52 ` Greg KH
2021-04-05 10:50 ` [PATCH v4 3/9] w1: ds2438: fixed a coding style issue in temperature_read Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 4/9] w1: ds2438: fixed a coding style issue in vad_read Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 5/9] w1: ds2438: fixed a coding style issue in vdd_read Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 6/9] w1: ds2438: fixed a coding style issue to preferred octal style Luiz Sampaio
2021-04-05 10:53 ` Greg KH
2021-04-05 12:47 ` Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 7/9] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 8/9] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 9/9] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-05 11:04 ` Greg KH
2021-04-05 12:44 ` Luiz Sampaio
2021-04-05 12:50 ` Greg KH [this message]
2021-04-05 10:53 ` [PATCH v4 0/9] w1: ds2438: adding support for calibration of current measurements Greg KH
2021-04-05 12:45 ` Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 " Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 1/6] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 2/6] w1: ds2438: fixed if brackets " Luiz Sampaio
2021-04-09 4:39 ` Joe Perches
2021-04-09 14:40 ` Joe Perches
2021-04-16 22:26 ` Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 3/6] w1: ds2438: fixed a " Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 4/6] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 5/6] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 6/6] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 0/9] w1: ds2438: adding support for calibration of current measurements Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 1/6] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 2/6] w1: ds2438: fixed if brackets " Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 3/6] w1: ds2438: fixed a " Luiz Sampaio
2021-04-09 9:44 ` kernel test robot
2021-04-09 10:43 ` kernel test robot
2021-04-10 8:38 ` Greg KH
2021-04-09 3:15 ` [PATCH v6 4/6] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 5/6] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 6/6] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 0/6] w1: ds2438: adding support for calibration of current measurements Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 1/6] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 2/6] w1: ds2438: fixed if brackets " Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 3/6] w1: ds2438: changed sysfs macro for rw file Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 4/6] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 5/6] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 6/6] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-17 5:25 ` kernel test robot
2021-05-14 11:47 ` [PATCH v7 0/6] w1: ds2438: adding support for calibration of current measurements Greg KH
2021-05-19 22:30 ` [PATCH v8 " Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 1/6] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 2/6] w1: ds2438: fixed if brackets " Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 3/6] w1: ds2438: changed sysfs macro for rw file Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 4/6] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 5/6] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 6/6] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-05 10:32 ` [PATCH v3 0/9] w1: ds2438: adding support for calibration of current measurements Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGsHmCkHj6SwUqhD@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=sampaio.ime@gmail.com \
--cc=zbr@lwn.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome