From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4351DC433ED for ; Tue, 20 Apr 2021 08:06:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12DE16127C for ; Tue, 20 Apr 2021 08:06:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229875AbhDTIGb (ORCPT ); Tue, 20 Apr 2021 04:06:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:55558 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbhDTIG2 (ORCPT ); Tue, 20 Apr 2021 04:06:28 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1618905956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QI+jU+hQq4MG4fnEZIyp1J+yoW7z3R2nnTri1hPIMb0=; b=LDwx87FWadOHK1RH2RC0IFbccjafULornqRJg3LIpFf66O+6qZ/1S6Teqsh1nd5G8PYKYe SX0GjTu6vo5dK98WipgCgvNj2KpHbjFV+9pgpliHBfHGvIuGWDbsJtuWuQ1Ok7NtjAxamm IPOMk7r5giucoElK3B7f8YLpbFMIyko= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 19398B23F; Tue, 20 Apr 2021 08:05:56 +0000 (UTC) Date: Tue, 20 Apr 2021 10:05:55 +0200 From: Michal Hocko To: Johannes Weiner Cc: Waiman Long , Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Muchun Song , Alex Shi , Chris Down , Yafang Shao , Wei Yang , Masayoshi Mizuma , Xing Zhengjun , Matthew Wilcox Subject: Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c Message-ID: References: <20210419000032.5432-1-longman@redhat.com> <20210419000032.5432-2-longman@redhat.com> <140444ea-14e7-b305-910f-f23fafe45488@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 19-04-21 17:11:37, Johannes Weiner wrote: > On Mon, Apr 19, 2021 at 01:26:29PM -0400, Waiman Long wrote: [...] > - the soft limit tree and soft limit reclaim > > - the threshold and oom event notification stuff > > - the charge moving code > > - remaining v1 interface files, as well as their helper functions > > From a quick scan, this adds up to ~2,500 lines of old code with no > actual dependencies from the common code or from v2, and which could > be moved out of the way without disrupting ongoing development much. Moving those into its own file makes sense to me as well. If the code is not conditional (e.g. like swap accounting and some others) then moving it would make memecontrol.c easier to navigate through. -- Michal Hocko SUSE Labs