From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E85C433B4 for ; Tue, 20 Apr 2021 10:16:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E3726103E for ; Tue, 20 Apr 2021 10:16:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231430AbhDTKQj (ORCPT ); Tue, 20 Apr 2021 06:16:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:48176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230408AbhDTKQh (ORCPT ); Tue, 20 Apr 2021 06:16:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B3D3F6103E; Tue, 20 Apr 2021 10:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618913765; bh=ywKEyiHWYClQI1Dmf/rkB4oZayawQuFh8fCIiiwQMC0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GGv/OALmF8O3hYRASifOtbcgAI3TjOxs2wBcV3W/tLLmQVvZmEE198xmCjRfhgcEB Z7WVddlioF8mTidJtG4eEFaMh9swtExXvNUeox2aCT1J/3nWJRpVefsDa/9MuLQ8p0 G0svygTczL0kXJb9RvH3rHZMisQALgoDP/Tt7QMlKXXp1pI3C6rQmnuVhh9nFuO5mz JasB47atzmXus6U/wHsAk07BnMY53PpJ4YL6/DNSI2hP1ypS8takaNUIkexY7aN4+A +vbzsUU3eEwZHa7Vy8nrfY5BZxqTxjXTVx7cXrXoN5lWo4PqQjMB184F7N8T3d5mTN 9nFZnGZhTFnDA== Date: Tue, 20 Apr 2021 15:46:01 +0530 From: Vinod Koul To: Colin King Cc: Dave Jiang , dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: idxd: Fix potential null dereference on pointer status Message-ID: References: <20210415110654.1941580-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210415110654.1941580-1-colin.king@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-04-21, 12:06, Colin King wrote: > From: Colin Ian King > > There are calls to idxd_cmd_exec that pass a null status pointer however > a recent commit has added an assignment to *status that can end up > with a null pointer dereference. The function expects a null status > pointer sometimes as there is a later assignment to *status where > status is first null checked. Fix the issue by null checking status > before making the assignment. Applied, thanks -- ~Vinod