From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12D39C43461 for ; Tue, 20 Apr 2021 14:49:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA893613C9 for ; Tue, 20 Apr 2021 14:49:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232745AbhDTOu1 (ORCPT ); Tue, 20 Apr 2021 10:50:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231682AbhDTOuX (ORCPT ); Tue, 20 Apr 2021 10:50:23 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B981C06174A; Tue, 20 Apr 2021 07:49:51 -0700 (PDT) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94 #2 (Red Hat Linux)) id 1lYrh8-006oXm-Sg; Tue, 20 Apr 2021 14:49:43 +0000 Date: Tue, 20 Apr 2021 14:49:42 +0000 From: Al Viro To: Arnd Bergmann Cc: Guo Ren , linux-riscv , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-arch , Guo Ren Subject: Re: [PATCH 2/3] nios2: Cleanup deprecated function strlen_user Message-ID: References: <1618925829-90071-1-git-send-email-guoren@kernel.org> <1618925829-90071-2-git-send-email-guoren@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 20, 2021 at 04:32:33PM +0200, Arnd Bergmann wrote: > On Tue, Apr 20, 2021 at 3:37 PM wrote: > > > > From: Guo Ren > > > > $ grep strlen_user * -r > > arch/csky/include/asm/uaccess.h:#define strlen_user(str) strnlen_user(str, 32767) > > arch/csky/lib/usercopy.c: * strlen_user: - Get the size of a string in user space. > > arch/ia64/lib/strlen.S: // Please note that in the case of strlen() as opposed to strlen_user() > > arch/mips/lib/strnlen_user.S: * make strlen_user and strnlen_user access the first few KSEG0 > > arch/nds32/include/asm/uaccess.h:extern __must_check long strlen_user(const char __user * str); > > arch/nios2/include/asm/uaccess.h:extern __must_check long strlen_user(const char __user *str); > > arch/riscv/include/asm/uaccess.h:extern long __must_check strlen_user(const char __user *str); > > kernel/trace/trace_probe_tmpl.h:static nokprobe_inline int fetch_store_strlen_user(unsigned long addr); > > kernel/trace/trace_probe_tmpl.h: ret += fetch_store_strlen_user(val + code->offset); > > kernel/trace/trace_uprobe.c:fetch_store_strlen_user(unsigned long addr) > > kernel/trace/trace_kprobe.c:fetch_store_strlen_user(unsigned long addr) > > kernel/trace/trace_kprobe.c: return fetch_store_strlen_user(addr); > > I would suggest using "grep strlen_user * -rw", to let the whole-word match > filter out the irrelevant ones for the changelog. > > > See grep result, nobody uses it. > > > > Signed-off-by: Guo Ren > > Cc: Arnd Bergmann > > All three patches > > Reviewed-by: Arnd Bergmann > > Do you want me to pick them up in the asm-generic tree? Might make sense to check -next from time to time... See a0d8d552783b "whack-a-mole: kill strlen_user() (again)" in there