From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38629C433ED for ; Sat, 10 Apr 2021 08:41:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5CD961185 for ; Sat, 10 Apr 2021 08:41:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234238AbhDJIlv (ORCPT ); Sat, 10 Apr 2021 04:41:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:59070 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233606AbhDJIlu (ORCPT ); Sat, 10 Apr 2021 04:41:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9746661184; Sat, 10 Apr 2021 08:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618044096; bh=89sN6PMXx2TMCv8HF7o7UTNzKaWHKjT2V/j8/AnQ4YA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uo+9ihhfOZ9HbZBGTjgLFFHrtZv/1PQWez1CISbSevSdEnUnY2J09SVrSxkATeD5W lSuLI1BPUDVQtu1OQngMCDBHhDRRzZH+UWSb8IyraN3qx+Xcy4LuEoQORjaE2kFTlC YDPTSim1z0q9qt8dpwBVAKSWouSj2cjkC7ggs3GM= Date: Sat, 10 Apr 2021 10:41:33 +0200 From: Greg KH To: Hillf Danton Cc: Jiri Slaby , linux-kernel@vger.kernel.org, Dmitry Vyukov , Hao Sun Subject: Re: [PATCH] tty: n_gsm: check error while registering tty devices Message-ID: References: <20210407021622.1417-1-hdanton@sina.com> <20210407082130.1586-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210407082130.1586-1-hdanton@sina.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 07, 2021 at 04:21:30PM +0800, Hillf Danton wrote: > On Wed, 7 Apr 2021 07:37:53 Jiri Slaby wrote: > > > >Yes, the fix makes sense. > > Thanks for taking a look. > > >But could you elaborate in the commit log when this happens? > >I only wonder how real this is. I assume you inject faults to allocations? > > After looking at Hao's report [1] again, I think you are right as it was > reported by syzbot too. Can you share the info you know about the syzbot > report, Hao, something like the line below with the Reported-by prefix? > > (This is just an example Reported-by: syzbot+b804f902bbb6bcf290cb@syzkaller.appspotmail.com) Yes, the changelog text here needs to be fixed up when you resend it to include this type of information. thanks, greg k-h