mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH v3 3/4] staging: rtl8723bs: Change the type and use of a variable
Date: Sun, 11 Apr 2021 10:39:13 +0200	[thread overview]
Message-ID: <YHK1sS6N/+dcxxhZ@kroah.com> (raw)
In-Reply-To: <20210411082908.31876-4-fmdefrancesco@gmail.com>

On Sun, Apr 11, 2021 at 10:29:07AM +0200, Fabio M. De Francesco wrote:
> Change the type of fw_current_in_ps_mode from u8 to bool, because
> it is used everywhere as a bool and, accordingly, it should be
> declared as a bool. Shorten the controlling expression of an 
> 'if' statement.

The "shorten" portion should be in patch 4/4 as it does the same thing
there, right?

Don't mix the two here, the changing of the type is fine to do alone as
a single patch and the if () change has nothing to do with that.

Also, you have trailing whitespace in your changelog text :(

thanks,

greg k-h

  reply	other threads:[~2021-04-11  8:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-11  8:29 [Outreachy kernel] [PATCH v3 0/4] staging: rtl8723bs: Change several files of the driver Fabio M. De Francesco
2021-04-11  8:29 ` [Outreachy kernel] [PATCH v3 1/4] staging: rtl8723bs: Remove camelcase in several files Fabio M. De Francesco
2021-04-11  8:29 ` [Outreachy kernel] [PATCH v3 2/4] staging: rtl8723bs: include: Fix misspelled words in comments Fabio M. De Francesco
2021-04-11  8:29 ` [Outreachy kernel] [PATCH v3 3/4] staging: rtl8723bs: Change the type and use of a variable Fabio M. De Francesco
2021-04-11  8:39   ` Greg KH [this message]
2021-04-11  8:29 ` [Outreachy kernel] [PATCH v3 4/4] staging: rtl8723bs: core: Change a controlling expression Fabio M. De Francesco
2021-04-11  9:26   ` Julia Lawall
2021-04-11  9:47     ` Fabio M. De Francesco
2021-04-11  9:51       ` Julia Lawall
2021-04-11 10:08         ` Fabio M. De Francesco
2021-04-11 10:10           ` Julia Lawall
2021-04-11 10:30             ` Fabio M. De Francesco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHK1sS6N/+dcxxhZ@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fmdefrancesco@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®