From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B8F3C433ED for ; Tue, 13 Apr 2021 13:26:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70AB9613B1 for ; Tue, 13 Apr 2021 13:26:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242005AbhDMN1K (ORCPT ); Tue, 13 Apr 2021 09:27:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:41002 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239438AbhDMN1A (ORCPT ); Tue, 13 Apr 2021 09:27:00 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1618320400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8lafVMVlqcvY7c180HwnbQQcnl+XANbCvOvXcaqEvjk=; b=N6gReKBQSdhU1VW+YK9rmRN4jLleRoXs4ljpABGoYdRcIM2f4OKid3cAr75hPq2sDgwTPu ejAEoVpn8ZjkdRhFJ3xlwbz9aTvCOGObVX1qXEWswIiyHl2WXeaFMXv0Ti3F/Vj83QrmAy YbNKHE08RV11LRp6wYTrfwd3+gevEaQ= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 78EDFAE89; Tue, 13 Apr 2021 13:26:40 +0000 (UTC) Date: Tue, 13 Apr 2021 15:26:39 +0200 From: Michal Hocko To: Oscar Salvador Cc: Andrew Morton , Mike Kravetz , Vlastimil Babka , David Hildenbrand , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 4/7] mm,hugetlb: Split prep_new_huge_page functionality Message-ID: References: <20210413104747.12177-1-osalvador@suse.de> <20210413104747.12177-5-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 13-04-21 15:24:32, Michal Hocko wrote: > On Tue 13-04-21 12:47:44, Oscar Salvador wrote: > [...] > > +static void prep_new_huge_page(struct hstate *h, struct page *page, int nid) > > +{ > > + __prep_new_huge_page(page); > > spin_lock_irq(&hugetlb_lock); > > - h->nr_huge_pages++; > > - h->nr_huge_pages_node[nid]++; > > + __prep_account_new_huge_page(h, nid); > > spin_unlock_irq(&hugetlb_lock); > > } > > Any reason to decouple the locking from the accounting? OK, I spoke too soon. The next patch already has the locking around when calling this. Please add a lockdep assert into the helper to make the locking expectations more obvious. With that Acked-by: Michal Hocko -- Michal Hocko SUSE Labs