From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0E26C433B4 for ; Wed, 14 Apr 2021 10:28:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD41B611C9 for ; Wed, 14 Apr 2021 10:28:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233731AbhDNK2i (ORCPT ); Wed, 14 Apr 2021 06:28:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:55646 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232235AbhDNK2g (ORCPT ); Wed, 14 Apr 2021 06:28:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4DFE1613BB; Wed, 14 Apr 2021 10:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618396093; bh=inLOHc4mEA6C0jmfnEWMrWnf4KZT+SYwxR2duFTHKco=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZzFHRemJebaD9YD5jVtByERtwtXJd3I9oEx+xDcAe5U6ZwAXcVcfxU/sZCNm5IA8/ s6YuJMnHMHrUHprR8iZt5AKNXb5qCpJcGg8e0sClB5Op7TlZ8XL+8PiOcPoZddqtN2 mL2vZHZMhiVOKJ7f+lHHN/LS4qo9zqwY8/7EVhgg= Date: Wed, 14 Apr 2021 12:28:11 +0200 From: Greg KH To: Fabio Aiuto Cc: julia.lawall@inria.fr, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/7] staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg() Message-ID: References: <20210414094340.GB3931@agape.jhs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414094340.GB3931@agape.jhs> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 14, 2021 at 11:43:41AM +0200, Fabio Aiuto wrote: > On Wed, Apr 14, 2021 at 10:26:01AM +0200, Greg KH wrote: > > > - DBG_871X_SEL_NL(sel, "%10s %16s %8s %10s %11s %14s\n", > > > - "TH_L2H_ini", "TH_EDCCA_HL_diff", "IGI_Base", > > > - "ForceEDCCA", "AdapEn_RSSI", "IGI_LowerBound"); > > > - DBG_871X_SEL_NL(sel, "0x%-8x %-16d 0x%-6x %-10d %-11u %-14u\n", > > > - (u8)odm->TH_L2H_ini, > > > - odm->TH_EDCCA_HL_diff, > > > - odm->IGI_Base, > > > - odm->ForceEDCCA, > > > - odm->AdapEn_RSSI, > > > - odm->IGI_LowerBound > > > - ); > > > + netdev_dbg(adapter->pnetdev, "%10s %16s %8s %10s %11s %14s\n", > > > + "TH_L2H_ini", "TH_EDCCA_HL_diff", "IGI_Base", "ForceEDCCA", > > > + "AdapEn_RSSI", "IGI_LowerBound");netdev_dbg(adapter->pnetdev, > > > + "0x%-8x %-16d 0x%-6x %-10d %-11u %-14u\n", > > > + (u8)odm->TH_L2H_ini, > > > + odm->TH_EDCCA_HL_diff, > > > + odm->IGI_Base, > > > + odm->ForceEDCCA, > > > + odm->AdapEn_RSSI, > > > + odm->IGI_LowerBound); > > > > Something went wrong with this change :( > > thanks Greg, I sent an example to Julia, that reproduce the problem. > As soon as it gets fixed I will send you a v2. You can fix it up yourself "by hand" for now, no need to wait for a tool fix :)