From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 793E7C433B4 for ; Thu, 15 Apr 2021 08:14:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56EF161158 for ; Thu, 15 Apr 2021 08:14:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231638AbhDOIOd (ORCPT ); Thu, 15 Apr 2021 04:14:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:56174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231346AbhDOIOb (ORCPT ); Thu, 15 Apr 2021 04:14:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 109D86113B; Thu, 15 Apr 2021 08:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618474448; bh=HiHLpUFvZ5VU+DrZiKgt+74waqG28Spmbkt47dl0/1E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gPX3XThKazMw+1Tzk9co5fVLXN0GZKY6yakDMQ7fiWSipklvY7oNVR9y/m2oAGMpg o/nhoPFilrCr34U+t7Le4NiJZno89Hsf534QuZ7gYxdN/3s1T20qT5exVmRYu/sB86 JWxAMVzX/mbTqNWdyzVUcUnwL6HE845Nnq1w6vlQ= Date: Thu, 15 Apr 2021 10:14:05 +0200 From: Greg Kroah-Hartman To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, Jiri Slaby , linux-serial@vger.kernel.org Subject: Re: [PATCH v2] serial: omap: fix rs485 half-duplex filtering Message-ID: References: <20210411093855.1053-1-dariobin@libero.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210411093855.1053-1-dariobin@libero.it> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 11, 2021 at 11:38:55AM +0200, Dario Binacchi wrote: > Data received during half-duplex transmission must be filtered. > If the target device responds quickly, emptying the FIFO at the end of > the transmission can erase not only the echo characters but also part of > the response message. > By keeping the receive interrupt enabled even during transmission, it > allows you to filter each echo character and only in a number equal to > those transmitted. > The issue was generated by a target device that started responding > 240us later having received a request in communication at 115200bps. > Sometimes, some messages received by the target were missing some of the > first bytes. > > Signed-off-by: Dario Binacchi > What commit id does this patch "fix"? Please resend that and add a "Fixes:" tag right above your signed-off-by line. thanks, greg k-h