From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07D39C43461 for ; Thu, 15 Apr 2021 13:37:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D80D8613C1 for ; Thu, 15 Apr 2021 13:37:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233192AbhDONhY (ORCPT ); Thu, 15 Apr 2021 09:37:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233090AbhDONhX (ORCPT ); Thu, 15 Apr 2021 09:37:23 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B32DC061574; Thu, 15 Apr 2021 06:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rmmd2MnkoiOz6+31WCvz2SljYBXG1ZHyCZdZS1oIPaw=; b=DGczTqARvMf/0/wZARvuJQXtcX fJ3VwdUbeGmOaliuJtMplXcQ/gNCn/1W3PiuUTikVMiXgZRabeYoywRbtPlp70jXwEkzsU8RAxG7y XH5vfGpFPib2JOZj83+F1zFn5CNsbSsroKjLSSWBBo/WvKEo1onXnApmqUkpbD846EeAvGRjytdD8 qBI5+5kcfy7mHVlmETIorUFQScHdrqGbXYrix+/n2dE9zfUzuXJH+i94u7AaI3dw6QTjKbIGDwPwA Q1z8qMLCMeQ/v4DT/mqRAcevDZSCGgsafjIXbUtKuBPEOCthWDeZEIhb4PBN620wdifwP9rx+4Lwy 2WtAvo9Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lX2Ak-00GHOV-GJ; Thu, 15 Apr 2021 13:36:42 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id D9459300212; Thu, 15 Apr 2021 15:36:40 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id AD84C2C12A6C2; Thu, 15 Apr 2021 15:36:40 +0200 (CEST) Date: Thu, 15 Apr 2021 15:36:40 +0200 From: Peter Zijlstra To: Alison Schofield Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Dave Hansen , Tony Luck , Tim Chen , "H. Peter Anvin" , David Rientjes , Igor Mammedov , Prarit Bhargava , brice.goglin@gmail.com Subject: Re: [PATCH v3] x86, sched: Treat Intel SNC topology as default, COD as exception Message-ID: References: <20210310190233.31752-1-alison.schofield@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210310190233.31752-1-alison.schofield@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 10, 2021 at 11:02:33AM -0800, Alison Schofield wrote: > Commit 1340ccfa9a9a ("x86,sched: Allow topologies where NUMA nodes > share an LLC") added a vendor and model specific check to never > call topology_sane() for Intel Skylake Server systems where NUMA > nodes share an LLC. > > Intel Ice Lake and Sapphire Rapids CPUs also enumerate an LLC that is > shared by multiple NUMA nodes. The LLC on these CPUs is shared for > off-package data access but private to the NUMA node for on-package > access. Rather than managing a list of allowable SNC topologies, make > this SNC topology the default, and treat Intel's Cluster-On-Die (COD) > topology as the exception. > > In SNC mode, Sky Lake, Ice Lake, and Sapphire Rapids servers do not > emit this warning: > > sched: CPU #3's llc-sibling CPU #0 is not on the same node! [node: 1 != 0]. Ignoring dependency. > > Acked-by: Dave Hansen > Suggested-by: Peter Zijlstra (Intel) > Signed-off-by: Alison Schofield Seeing how this is basically what I gave you earlier; but now tested and with comments on, Acked-by: Peter Zijlstra (Intel) Boris, will you make it happen, or you want me to queue it somewhere x86/core like?