From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC99C433B4 for ; Thu, 15 Apr 2021 13:48:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F05A261222 for ; Thu, 15 Apr 2021 13:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233191AbhDONtQ (ORCPT ); Thu, 15 Apr 2021 09:49:16 -0400 Received: from 8bytes.org ([81.169.241.247]:35046 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230056AbhDONtE (ORCPT ); Thu, 15 Apr 2021 09:49:04 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 6A328387; Thu, 15 Apr 2021 15:48:40 +0200 (CEST) Date: Thu, 15 Apr 2021 15:48:38 +0200 From: Joerg Roedel To: Yong Wu Cc: Will Deacon , Matthias Brugger , Robin Murphy , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Krzysztof Kozlowski , youlin.pei@mediatek.com, anan.sun@mediatek.com, chao.hao@mediatek.com, Valdis Kletnieks Subject: Re: [PATCH 1/2] iommu/mediatek-v1: Avoid build fail when build as module Message-ID: References: <20210412064843.11614-1-yong.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210412064843.11614-1-yong.wu@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 12, 2021 at 02:48:42PM +0800, Yong Wu wrote: > When this driver build as module, It build fail like: > > ERROR: modpost: "of_phandle_iterator_args" > [drivers/iommu/mtk_iommu_v1.ko] undefined! > > This patch remove this interface to avoid this build fail. > > Reported-by: Valdis Kletnieks > Signed-off-by: Yong Wu > --- > Currently below patch is only in linux-next-20210409. This fixes tag may be > not needed. we can add this if it is need. > Fixes: 8de000cf0265 ("iommu/mediatek-v1: Allow building as module") > --- > drivers/iommu/mtk_iommu_v1.c | 62 ++++++++++++++++-------------------- > 1 file changed, 28 insertions(+), 34 deletions(-) Applied both, thanks.