From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70391C433ED for ; Fri, 16 Apr 2021 00:22:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D0A96113D for ; Fri, 16 Apr 2021 00:22:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235133AbhDPAWd (ORCPT ); Thu, 15 Apr 2021 20:22:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234716AbhDPAWc (ORCPT ); Thu, 15 Apr 2021 20:22:32 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1406C061574 for ; Thu, 15 Apr 2021 17:22:08 -0700 (PDT) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94 #2 (Red Hat Linux)) id 1lXCF6-005dLJ-Fl; Fri, 16 Apr 2021 00:21:52 +0000 Date: Fri, 16 Apr 2021 00:21:52 +0000 From: Al Viro To: Christoph Hellwig Cc: Palmer Dabbelt , Damien Le Moal , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, jcmvbkbc@gmail.com, gerg@linux-m68k.org, Anup Patel , uclinux-dev@uclinux.org Subject: Re: [PATCH v2 0/2] Fix binfmt_flat loader for RISC-V Message-ID: References: <20210415055605.GB8947@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210415055605.GB8947@lst.de> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 15, 2021 at 07:56:05AM +0200, Christoph Hellwig wrote: > binfmt_flat tends to go through Greg's uclinux tree, adding him and > the list. FWIW, my involvement with binfmt_flat had been pretty much nil - the least trivial had been "binfmt_flat: flat_{get,put}_addr_from_rp() should be able to fail" about 4 years ago and that fell out of hunting for places where __get_user() had been used without checking error values. It's in fs/*, but I've no way to test it and I have pretty much zero familiarity with the guts of that one, so I can't give any useful feedback on that series. So consider the Christoph's comment seconded - you want it reviewed by gerg et.al., and it probably ought to go via gerg/uclinux.git tree. I'm reasonably familiar with binfmt_{elf,misc,script}; anything else gets touched as part of larger series and only with sanity checks from other folks, if the changes are not entirely trivial.