From: Peter Zijlstra <peterz@infradead.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>, Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <ak@linux.intel.com>, Ian Rogers <irogers@google.com>,
Song Liu <songliubraving@fb.com>, Tejun Heo <tj@kernel.org>,
kernel test robot <lkp@intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v3 1/2] perf/core: Share an event with multiple cgroups
Date: Fri, 16 Apr 2021 12:27:55 +0200 [thread overview]
Message-ID: <YHlmq2q4nNSqJBw6@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <YHlY+qd2hF00OrFw@hirez.programming.kicks-ass.net>
On Fri, Apr 16, 2021 at 11:29:30AM +0200, Peter Zijlstra wrote:
> > So I think we've had proposals for being able to close fds in the past;
> > while preserving groups etc. We've always pushed back on that because of
> > the resource limit issue. By having each counter be a filedesc we get a
> > natural limit on the amount of resources you can consume. And in that
> > respect, having to use 400k fds is things working as designed.
> >
> > Anyway, there might be a way around this..
So how about we flip the whole thing sideways, instead of doing one
event for multiple cgroups, do an event for multiple-cpus.
Basically, allow:
perf_event_open(.pid=fd, cpu=-1, .flag=PID_CGROUP);
Which would have the kernel create nr_cpus events [the corrolary is that
we'd probably also allow: (.pid=-1, cpu=-1) ].
Output could be done by adding FORMAT_PERCPU, which takes the current
read() format and writes a copy for each CPU event. (p)read(v)() could
be used to explode or partial read that.
This gets rid of the nasty variadic nature of the
'get-me-these-n-cgroups'. While still getting rid of the n*m fd issue
you're facing.
next prev parent reply other threads:[~2021-04-16 10:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 15:53 [PATCH v3 0/2] perf core: Sharing events " Namhyung Kim
2021-04-13 15:53 ` [PATCH v3 1/2] perf/core: Share an event " Namhyung Kim
2021-04-15 14:51 ` Peter Zijlstra
2021-04-15 23:48 ` Namhyung Kim
2021-04-16 9:26 ` Peter Zijlstra
2021-04-16 9:29 ` Peter Zijlstra
2021-04-16 10:19 ` Namhyung Kim
2021-04-16 10:27 ` Peter Zijlstra [this message]
2021-04-16 11:22 ` Namhyung Kim
2021-04-16 11:59 ` Peter Zijlstra
2021-04-16 12:19 ` Namhyung Kim
2021-04-16 13:39 ` Peter Zijlstra
2021-05-09 7:13 ` Namhyung Kim
2021-04-16 10:18 ` Namhyung Kim
2021-04-16 9:49 ` Namhyung Kim
2021-04-20 10:28 ` Peter Zijlstra
2021-04-20 18:37 ` Namhyung Kim
2021-04-20 18:43 ` Peter Zijlstra
2021-04-20 8:34 ` Stephane Eranian
2021-04-20 9:48 ` Peter Zijlstra
2021-04-20 11:28 ` Peter Zijlstra
2021-04-21 19:37 ` Namhyung Kim
2021-05-03 21:53 ` Namhyung Kim
2021-04-13 15:53 ` [PATCH v3 2/2] perf/core: Support reading group events with shared cgroups Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHlmq2q4nNSqJBw6@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®