From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URI_TRY_3LD autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1512C43460 for ; Fri, 16 Apr 2021 12:52:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA10761153 for ; Fri, 16 Apr 2021 12:52:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240467AbhDPMwd (ORCPT ); Fri, 16 Apr 2021 08:52:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:35856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235225AbhDPMw1 (ORCPT ); Fri, 16 Apr 2021 08:52:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BDDFD61107; Fri, 16 Apr 2021 12:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618577523; bh=hwJ8s62yDIzmzZA0XYf+y6HvC+HhisQjYC0WgN+PGKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G2m/SWVf8QKqq/Btcd4gPFqAbLsDT34XDLpJddTRhYn/QOuv+nKJIwxo3d7jjSkDU 1kAc68zdjhib0EwVoAVObGVbxEAG44nHvsCbKiduv7cvk1eaydVObPt+GcJUWUNW1B jgyNLtAyDs+vdJYNMEiRjh+obC8KOE9gUdTmYock= Date: Fri, 16 Apr 2021 14:51:59 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Jan Sebastian =?iso-8859-1?Q?G=F6tte?= , Phil Reid , Nishad Kamdar Subject: Re: [PATCH v1 1/2] fbtft: Rectify GPIO handling Message-ID: References: <20210416123117.4993-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416123117.4993-1-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 16, 2021 at 03:31:16PM +0300, Andy Shevchenko wrote: > The infamous commit c440eee1a7a1 ("Staging: fbtft: Switch to > the GPIO descriptor interface") broke GPIO handling completely. > It has already four commits to rectify and it seems not enough. > In order to fix the mess here we: > > 1) Set default to "inactive" for all requested pins > > 2) Fix CS, RD, and WR pins polarity since it's active low and > GPIO descriptor interface takes it into consideration from > the Device Tree or ACPI > > 3) Fix RESET pin polarity in the places missed by the commit > b918d1c27066 ("Staging: fbtft: Fix reset assertion when using gpio descriptor") > > 4) Consolidate chip activation (CS assert) under default > ->reset() callback > > To summarize the expectations about polarity for GPIOs: > > #RD Low > #WR Low > #CS Low > #RESET Low > DC or RS High > RW High > Data 0..15 High > > See also Adafruit learning course [1] for the example of the schematics. > > While at it, drop unneeded NULL checks, since GPIO API is tolerant to that. > At the end, update TODO to mark this job eventually done. > > [1]: https://learn.adafruit.com/adafruit-2-8-and-3-2-color-tft-touchscreen-breakout-v2/downloads Shouldn't this be broken up into "one patch per thing" from your list above? Feels like you did a lot of different things all in the same patch :( thanks, greg k-h