From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6927AC433B4 for ; Mon, 3 May 2021 09:54:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 425AC6120E for ; Mon, 3 May 2021 09:54:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233200AbhECJze (ORCPT ); Mon, 3 May 2021 05:55:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232964AbhECJzd (ORCPT ); Mon, 3 May 2021 05:55:33 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32265C06174A for ; Mon, 3 May 2021 02:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tTd9eo00Ue3wFKj+8UCV8oHUSbnAPYsBUziBG+5QfHY=; b=p6/fXoHfBsno7l+5+4dQMtHRF4 cCTUOAqI7cf7sCGY1DkqE4KsC58d1OWn9e3g2J9SmWiAGfVkCv188brbWho5lWuygWY7zSnf/Inhe MbZDuxLRQEUCPLtxGEKKh55z6eG1A1ZN9WyL2PwovEd0/ENqbpMHFtHtctSG17J/tJmlZZCFMgr/y lkfeVMBgaQNYJ+NfUV8hsxvtQ5CbVAHZwbssRTpeMz6i5fH4Ch2/FidTXkiQThKv0zIglkto7DuhC bRt5VFpi5mGIp4jLWKw/T+zsnNO4MmsTdQKWepUdXMvn+NREMCOx0uKCV1sLA+38JYsuotqdMLXtI OcY0lDeQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1ldVHH-00Daqu-MN; Mon, 03 May 2021 09:54:12 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 4CE71300036; Mon, 3 May 2021 11:54:11 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 270C42BC22563; Mon, 3 May 2021 11:54:11 +0200 (CEST) Date: Mon, 3 May 2021 11:54:11 +0200 From: Peter Zijlstra To: Ricardo Neri Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Len Brown , Srinivas Pandruvada , Tim Chen , Aubrey Li , "Ravi V. Shankar" , Ricardo Neri , Quentin Perret , "Joel Fernandes (Google)" , linux-kernel@vger.kernel.org, Aubrey Li , Ben Segall , Daniel Bristot de Oliveira Subject: Re: [PATCH v2 3/4] sched/fair: Consider SMT in ASYM_PACKING load balance Message-ID: References: <20210414020436.12980-1-ricardo.neri-calderon@linux.intel.com> <20210414020436.12980-4-ricardo.neri-calderon@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414020436.12980-4-ricardo.neri-calderon@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 13, 2021 at 07:04:35PM -0700, Ricardo Neri wrote: > +/** > + * asym_can_pull_tasks - Check whether the load balancing CPU can pull tasks > + * @dst_cpu: CPU doing the load balancing FWIW, that description isn't correct. dst_cpu does not need to be the CPU doing the actual balancing. It mostly is, but no guarantees.