From: Peter Zijlstra <peterz@infradead.org>
To: Hui Su <suhui@zeku.com>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/fair.c: add helper func for util_avg and runnable_avg calc
Date: Thu, 22 Apr 2021 13:51:54 +0200 [thread overview]
Message-ID: <YIFjWrAZ6Fw4bFQd@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210422091416.19432-1-suhui@zeku.com>
On Thu, Apr 22, 2021 at 05:14:16PM +0800, Hui Su wrote:
> add helper func for util_avg and runnable_avg calc when entity
> enqueue and dequeue. No functional change.
>
> without this change:
> size vmlinux
> text data bss dec hex filename
> 19889268 6632812 2429160 28951240 1b9c2c8 vmlinux
> size kernel/sched/fair.o
> text data bss dec hex filename
> 40044 1569 96 41709 a2ed kernel/sched/fair.o
> ubuntu@zeku_server:~/workspace/linux-stable $
>
> with this change:
> size vmlinux
> text data bss dec hex filename
> 19889268 6632812 2429160 28951240 1b9c2c8 vmlinux
> size kernel/sched/fair.o
> text data bss dec hex filename
> 40044 1569 96 41709 a2ed kernel/sched/fair.o
>
> Signed-off-by: Hui Su <suhui@zeku.com>
> ---
> kernel/sched/fair.c | 48 +++++++++++++++++++++++++++++++++++++--------
> 1 file changed, 40 insertions(+), 8 deletions(-)
So you're increasing line-count and clutter for absolutely no benefit.
Why would we want that?
prev parent reply other threads:[~2021-04-22 11:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 9:14 Hui Su
2021-04-22 11:51 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIFjWrAZ6Fw4bFQd@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=suhui@zeku.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®