From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47137C433ED for ; Fri, 23 Apr 2021 17:45:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D9716140F for ; Fri, 23 Apr 2021 17:45:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243368AbhDWRqd (ORCPT ); Fri, 23 Apr 2021 13:46:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:39500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229691AbhDWRqc (ORCPT ); Fri, 23 Apr 2021 13:46:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 03E1F61404; Fri, 23 Apr 2021 17:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619199955; bh=te6gbiVsFycG/DzVBbSa//ghoSy8WlqKQPVlGffimCE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KvtwE9+lNuZytwcCZms0U8vJotk1uRw01D1p0aGr9UOEKYpsKvfTJogmBiY8Jr9Nr IqDqss1TVzUGdBY0EinfRXkvNgBm9zZSiFJnYZPxsBx0vQVRKpf79V+VCMNv/wLIsl q1MmUnCnoaVPd1ZYxHlE0mabp4ZjPa5pPPFZICLiQOcD6RvzfMr56MPGzIdxmzfih0 SHRoDN0KO8D/AiH9V8O2T4q3OLDRMMpFhqoz0uX1j+oWRwPsnguoB2l/So1jMhQlge 0Rb15+7qPRydHO2rPjHxV2j1mQZZGLC+n9yHWKeKi4lpZxa5PoHqE1yWD6SSH2Szjp 78MjBjPthPFFg== Date: Fri, 23 Apr 2021 23:15:51 +0530 From: Vinod Koul To: Tom Zanussi Cc: peterz@infradead.org, acme@kernel.org, mingo@kernel.org, kan.liang@linux.intel.com, dave.jiang@intel.com, tony.luck@intel.com, dan.j.williams@intel.com, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH v3 0/2] dmaengine: idxd: IDXD pmu support Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21-04-21, 16:04, Tom Zanussi wrote: > Hi, > > This is v3 of the IDXD pmu support patch, which addresses the comments > from Vinod: > > - Removed the default line for INTEL_IDXD_PERFMON making it default 'n' > > - Replaced #ifdef CONFIG_INTEL_IDXD_PERFMON with IS_ENABLED() > > - Split the patch into two separate patches, the perfmon > implementation and the code that uses it in the IDXD driver. > > - Added a new file, > Documentation/ABI/testing/sysfs-bus-event_source-devices-dsa that > documents the new format and cpumask attributes, and added better > comments for those in the code. > > - Changed 'dogrp' to 'do_group' in perfmon_collect_events() > > - Moved 'int idx' inside the loop in perfmon_validate_group() to the > top of function. > > - In perfmon_pmu_read_counter(), return ioread64() directly and get > rid of cntrdata. > > I also fixed some erroneous code in perfmon_counter_overflow() that > because of my misreading of the spec caused unintended clearing of > wrong bits. According to the spec you need to write 1 rather than 0 > to an OVFSTATUS bit to clear it. Applied, thanks This conflicted with Daves patches, I managed to resolve, pls check the end result -- ~Vinod