From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>
Subject: Re: [PATCHSET 0/5] perf report: Make --stat output more compact
Date: Sat, 24 Apr 2021 14:23:19 +0200 [thread overview]
Message-ID: <YIQNtxTku/JihU+s@krava> (raw)
In-Reply-To: <20210423184647.GN1401198@tassilo.jf.intel.com>
On Fri, Apr 23, 2021 at 11:46:47AM -0700, Andi Kleen wrote:
> > So I added --skip-empty (and --no-skip-empty automatically) to suppres
> > the 0 output and add the event stats like below.
>
> I doubt we need the option for this.
I agree this could be default, but I'm getting compilation fail:
CC ui/browsers/hists.o
ui/browsers/hists.c: In function ‘hist_browser__handle_hotkey’:
ui/browsers/hists.c:699:29: error: ‘struct hists_stats’ has no member named ‘nr_lost_warned’
699 | (browser->hists->stats.nr_lost_warned !=
| ^
ui/browsers/hists.c:700:28: error: ‘struct hists_stats’ has no member named ‘nr_events’
700 | browser->hists->stats.nr_events[PERF_RECORD_LOST])) {
| ^
ui/browsers/hists.c:701:25: error: ‘struct hists_stats’ has no member named ‘nr_lost_warned’
701 | browser->hists->stats.nr_lost_warned =
| ^
ui/browsers/hists.c:702:26: error: ‘struct hists_stats’ has no member named ‘nr_events’
702 | browser->hists->stats.nr_events[PERF_RECORD_LOST];
| ^
ui/browsers/hists.c: In function ‘perf_evsel_menu__write’:
ui/browsers/hists.c:3419:40: error: ‘struct hists_stats’ has no member named ‘nr_events’
3419 | unsigned long nr_events = hists->stats.nr_events[PERF_RECORD_SAMPLE];
| ^
ui/browsers/hists.c:3435:33: error: ‘struct hists_stats’ has no member named ‘nr_events’
3435 | nr_events += pos_hists->stats.nr_events[PERF_RECORD_SAMPLE];
| ^
ui/browsers/hists.c:3444:26: error: ‘struct hists_stats’ has no member named ‘nr_events’
3444 | nr_events = hists->stats.nr_events[PERF_RECORD_LOST];
| ^
ui/browsers/hists.c: In function ‘block_hists_browser__title’:
ui/browsers/hists.c:3650:41: error: ‘struct hists_stats’ has no member named ‘nr_events’
3650 | unsigned long nr_samples = hists->stats.nr_events[PERF_RECORD_SAMPLE];
| ^
jirka
>
> But if you change it I would add the percentages after the absolute values.
>
> -Andi
>
next prev parent reply other threads:[~2021-04-24 12:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 18:28 Namhyung Kim
2021-04-23 18:28 ` [PATCH 1/5] perf top: Use evlist->events_stat to count events Namhyung Kim
2021-04-23 18:28 ` [PATCH 2/5] perf hists: Split hists_stats from events_stats Namhyung Kim
2021-04-23 18:28 ` [PATCH 3/5] perf report: Show event sample counts in --stat output Namhyung Kim
2021-04-23 18:28 ` [PATCH 4/5] perf report: Add --skip-empty option to suppress 0 event stat Namhyung Kim
2021-04-23 18:28 ` [PATCH 5/5] perf report: Make --skip-empty as default Namhyung Kim
2021-04-23 18:46 ` [PATCHSET 0/5] perf report: Make --stat output more compact Andi Kleen
2021-04-23 19:00 ` Namhyung Kim
2021-04-23 20:20 ` Andi Kleen
2021-04-25 18:07 ` Namhyung Kim
2021-04-26 4:31 ` Andi Kleen
2021-04-26 12:53 ` Arnaldo Carvalho de Melo
2021-04-24 12:23 ` Jiri Olsa [this message]
2021-04-25 18:03 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIQNtxTku/JihU+s@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome