From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4096C433ED for ; Wed, 5 May 2021 16:20:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEF7B6121F for ; Wed, 5 May 2021 16:20:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233983AbhEEQVs (ORCPT ); Wed, 5 May 2021 12:21:48 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:54640 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233857AbhEEQVr (ORCPT ); Wed, 5 May 2021 12:21:47 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1leKGU-002hN8-IW; Wed, 05 May 2021 18:20:46 +0200 Date: Wed, 5 May 2021 18:20:46 +0200 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function Message-ID: References: <20210308153703.23097-1-kabel@kernel.org> <20210429083636.22560-1-pali@kernel.org> <20210505180433.550178c8@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210505180433.550178c8@thinkpad> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 05, 2021 at 06:04:33PM +0200, Marek Behún wrote: > On Mon, 3 May 2021 14:22:49 +0200 > Andrew Lunn wrote: > > > On Thu, Apr 29, 2021 at 10:36:31AM +0200, Pali Rohár wrote: > > > From: Marek Behún > > > > > > The status decoding function mox_get_status() currently contains a dead > > > code path: if the error status is not MBOX_STS_SUCCESS, it always > > > returns -EIO, so the comparison to MBOX_STS_FAIL is never executed and > > > we don't get the actual error code sent by the firmware. > > > > > > Fix this. > > > > > > Signed-off-by: Marek Behún > > > Fixes: 389711b37493 ("firmware: Add Turris Mox rWTM firmware driver") > > > > You have put a fixes tag here, meaning you want it in stable? How does > > dead code elimination fulfil the stable requirements? > > > > Do any of these changes contain real fixes? > > > > Andrew > > Andrew, this is not dead code elimination. Please word you commit message differently. The status decoding function mox_get_status() currently contains an incorrect check: ... Andrew