mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Wei Ming Chen <jj251510319013@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_pci: Use fallthrough pseudo-keyword
Date: Fri, 7 May 2021 15:20:56 +0200	[thread overview]
Message-ID: <YJU+uJcJ6Y+2PEUc@kroah.com> (raw)
In-Reply-To: <20210507130403.11144-1-jj251510319013@gmail.com>

On Fri, May 07, 2021 at 09:04:03PM +0800, Wei Ming Chen wrote:
> Add pseudo-keyword macro fallthrough[1]
> 
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>
> ---
>  drivers/tty/serial/8250/8250_pci.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index 689d8227f95f..4158f06de4d5 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -847,8 +847,11 @@ static int pci_netmos_init(struct pci_dev *dev)
>  
>  	switch (dev->device) { /* FALLTHROUGH on all */
>  	case PCI_DEVICE_ID_NETMOS_9904:
> +		fallthrough;
>  	case PCI_DEVICE_ID_NETMOS_9912:
> +		fallthrough;
>  	case PCI_DEVICE_ID_NETMOS_9922:
> +		fallthrough;
>  	case PCI_DEVICE_ID_NETMOS_9900:

I really doubt this is needed here.  If so, something is really wrong
with the static checkers.

thanks,

greg k-h

      reply	other threads:[~2021-05-07 13:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-07 13:04 Wei Ming Chen
2021-05-07 13:20 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJU+uJcJ6Y+2PEUc@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jj251510319013@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®