From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93FFCC433B4 for ; Sat, 8 May 2021 10:58:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7165861414 for ; Sat, 8 May 2021 10:58:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230431AbhEHK7M (ORCPT ); Sat, 8 May 2021 06:59:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:55644 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230234AbhEHK7L (ORCPT ); Sat, 8 May 2021 06:59:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 878E861414; Sat, 8 May 2021 10:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620471489; bh=H/jXYFQXLAmIIakuyQqiit+5QqWQgTX/kFXq/0VpIH4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pyLiTcFH2B0Q2YAJfl0liVNUB0fK2q7FFh4C1w8szsHQNO6/vid52u/4UVXRyZTyw Hkxyl3Gh1MMidre9szM/jhDt+yRgH498gZaWA5MRNrcixxa3Y9bcCYVg5EkML4RIzE yfXlB9zt1DWTxUxdhly5vK256JvflOcAruNgwyLM= Date: Sat, 8 May 2021 12:58:06 +0200 From: Greg KH To: Pavel Skripkin Cc: mchehab@kernel.org, sakari.ailus@linux.intel.com, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: media: atomisp: code cleanup Message-ID: References: <20210507075458.GB3@paasikivi.fi.intel.com> <20210508105129.2698-1-paskripkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210508105129.2698-1-paskripkin@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 08, 2021 at 01:51:29PM +0300, Pavel Skripkin wrote: > Breaks are not useful after a return, they can > simply be removed. > > Also, dropped the individual return statements > after or inside switch cases Almost always, when you say "also" in a patch changelog, that means this should be split up into two different patches. I recommend doing that here as well, this should be a 2 patch series, right? thanks, greg k-h