From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9529C433ED for ; Sat, 8 May 2021 17:39:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8F7061401 for ; Sat, 8 May 2021 17:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbhEHRkF (ORCPT ); Sat, 8 May 2021 13:40:05 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:59450 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbhEHRkC (ORCPT ); Sat, 8 May 2021 13:40:02 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lfQum-003Hth-Pp; Sat, 08 May 2021 19:38:56 +0200 Date: Sat, 8 May 2021 19:38:56 +0200 From: Andrew Lunn To: Ansuel Smith Cc: Florian Fainelli , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH net-next v4 05/28] net: dsa: qca8k: use iopoll macro for qca8k_busy_wait Message-ID: References: <20210508002920.19945-1-ansuelsmth@gmail.com> <20210508002920.19945-5-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210508002920.19945-5-ansuelsmth@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 08, 2021 at 02:28:55AM +0200, Ansuel Smith wrote: > Use iopoll macro instead of while loop. > > Signed-off-by: Ansuel Smith > --- > drivers/net/dsa/qca8k.c | 23 +++++++++++------------ > drivers/net/dsa/qca8k.h | 2 ++ > 2 files changed, 13 insertions(+), 12 deletions(-) > > diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c > index 0b295da6c356..0bfb7ae4c128 100644 > --- a/drivers/net/dsa/qca8k.c > +++ b/drivers/net/dsa/qca8k.c > @@ -262,21 +262,20 @@ static struct regmap_config qca8k_regmap_config = { > static int > qca8k_busy_wait(struct qca8k_priv *priv, u32 reg, u32 mask) > { > - unsigned long timeout; > - > - timeout = jiffies + msecs_to_jiffies(20); > + u32 val; > + int ret; > > - /* loop until the busy flag has cleared */ > - do { > - u32 val = qca8k_read(priv, reg); > - int busy = val & mask; > + ret = read_poll_timeout(qca8k_read, val, !(val & mask), > + 0, QCA8K_BUSY_WAIT_TIMEOUT * USEC_PER_MSEC, false, > + priv, reg); > > - if (!busy) > - break; > - cond_resched(); > - } while (!time_after_eq(jiffies, timeout)); > + /* Check if qca8k_read has failed for a different reason > + * before returnting -ETIMEDOUT returning With that fixed Reviewed-by: Andrew Lunn Andrew